Deleting an Active Plugin via Bulk Actions Fails Silently

[mrwweb]

With the introduction of shinier updates in 4.6, it appears that the error messaging around deleting an activated plugin wasn't ported into the new system properly.

To reproduce:

1. On Plugins Screen, select an activated plugin.
2. From "Bulk Actions" select "Delete"
3. Click Apply

Result:

Nothing happens. Silent failure (to delete).

Expected Result:

Error message explaining that you can't delete activated plugins.

In one case, I actually saw the expected error message after refreshing the plugins page, but I haven't been able to replicate that since.

[swissspidy]

Thanks for your report. I can confirm the issue.

[swissspidy]

This really must have slipped under the radar somehow. There was no JS template for bulk deletions or anything. Luckily, it is easy to fix.

38112.diff​ addresses the issue. @mrwweb Can you test this on your site to see if it works for you as well?

[swissspidy]

Here's a screenshot after attempting to delete an inactive and an active plugin:

Now I've alse tested on multisite where it doesn't work at all :(

Theme deletion error message is undefined but the theme is deleted anyway after the second attempt:

Plugin deletion error messages work, but somehow there's also an inline error message:

[swissspidy]

I couldn't reproduce the undefined bug and I don't know why deleting a network enabled theme is even possible.

38112.2.diff​ changes the selector in wp.updates.deletePluginError to show the bulk admin notice and the inline notice. This makes the bug at least more obvious for both screens during testing.
Unfortunately, I haven't found a good solution yet to hide inline admin notices during a bulk action. The bulk handler would need to pass custom success & error callbacks instead of hooking into the triggers inside wp.updates.deletePluginError() et al. Ideally, the inline notices should not be added in wp.updates.deletePluginError() directly, but also via the hook.

[SergeyBiryukov]

#47337 was marked as a duplicate.

[SergeyBiryukov]

#49887 was marked as a duplicate.

[SergeyBiryukov]

#56613 was marked as a duplicate.

[ugyensupport]

@SergeyBiryukov @swissspidy Is this 38112.2.diff patch save to test with WordPress 6.8.2 or We are expecting new patch

[ankitkumarshah]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/38112/38112.2.diff

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.29
• Server: nginx/1.29.0
• Database: mysqli (Server: 8.0.43 / Client: mysqlnd 8.2.29)
• Browser: Chrome 138.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.3

Actual Results

1. 🟡 The primary issue has been resolved by the patch; however, an empty notice now appears at the top of the page.

Additional Notes

• Although the issue is resolved with the patch, I can see there is a blank empty notice on top:

Supplemental Artifacts

Trac ticket: https://core.trac.wordpress.org/ticket/38112

[ankitkumarshah]

I traced this regression back to the introduction of Shiny Updates in WordPress 4.6.
Specifically, commit:
​https://github.com/WordPress/wordpress-develop/commit/af6b1a53880206cc18e850709d3d1ccbf1d5375b#diff-9a2e3d033a5adf8f4fc1c7e757771440e5645dee7f34a248e23a7cb8dc18e6c1

(July 27 2016) Modified the plugin deletion/update flow and capability checks in wp_ajax_delete_plugin() and the related JS handling in updates.js.

[nikunj8866]

@ankitkumarshah I've refreshed the code. Could you please re-test it?

[SirLouen]

@nikunj8866 I think you wanted to set has-test-info right?

[nikunj8866]

@SirLouen, I've fixed the empty notice issue in the refresh code, so I'd like to re-test it.

[ankitkumarshah]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/9419

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.29
• Server: nginx/1.29.0
• Database: mysqli (Server: 8.0.43 / Client: mysqlnd 8.2.29)
• Browser: Chrome 138.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.3

Actual Results

1. ✅ Issue resolved with the patch.

Supplemental Artifacts

[ugyensupport]

Deleting an Active Plugin via Bulk Actions Fails Silently

Description

With the introduction of shinier updates in 4.6, it appears that the error messaging around deleting an activated plugin wasn't ported into the new system properly.

To reproduce:

On Plugins Screen, select an activated plugin.
From "Bulk Actions" select "Delete"
Click Apply
Result:

Nothing happens. Silent failure (to delete).

Expected Result:

Error message explaining that you can't delete activated plugins.

In one case, I actually saw the expected error message after refreshing the plugins page, but I haven't been able to replicate that since.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/9419/files

Environment

• WordPress: 6.8.3-alpha-60531
• PHP: 8.3.14
• Server: Apache/2.4.62 (Unix) mod_wsgi/5.0.1 Python/3.12 mod_fastcgi/mod_fastcgi-SNAP-0910052141 OpenSSL/1.1.1w
• Database: mysqli (Server: 5.7.44 / Client: mysqlnd 8.3.14)
• Browser: Chrome 139.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.3
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0
  • WordPress Beta Tester 3.6.4

Actual Results

1. ✅ Issue resolved with patch.

Additional Notes

• ​https://fileport.io/2X7WdXTReWsb