Deleting an Active Plugin via Bulk Actions Fails Silently

[mrwweb]

With the introduction of shinier updates in 4.6, it appears that the error messaging around deleting an activated plugin wasn't ported into the new system properly.

To reproduce:

1. On Plugins Screen, select an activated plugin.
2. From "Bulk Actions" select "Delete"
3. Click Apply

Result:

Nothing happens. Silent failure (to delete).

Expected Result:

Error message explaining that you can't delete activated plugins.

In one case, I actually saw the expected error message after refreshing the plugins page, but I haven't been able to replicate that since.

[swissspidy]

Thanks for your report. I can confirm the issue.

[swissspidy]

This really must have slipped under the radar somehow. There was no JS template for bulk deletions or anything. Luckily, it is easy to fix.

38112.diff​ addresses the issue. @mrwweb Can you test this on your site to see if it works for you as well?

[swissspidy]

Here's a screenshot after attempting to delete an inactive and an active plugin:

Now I've alse tested on multisite where it doesn't work at all :(

Theme deletion error message is undefined but the theme is deleted anyway after the second attempt:

Plugin deletion error messages work, but somehow there's also an inline error message:

[swissspidy]

I couldn't reproduce the undefined bug and I don't know why deleting a network enabled theme is even possible.

38112.2.diff​ changes the selector in wp.updates.deletePluginError to show the bulk admin notice and the inline notice. This makes the bug at least more obvious for both screens during testing.
Unfortunately, I haven't found a good solution yet to hide inline admin notices during a bulk action. The bulk handler would need to pass custom success & error callbacks instead of hooking into the triggers inside wp.updates.deletePluginError() et al. Ideally, the inline notices should not be added in wp.updates.deletePluginError() directly, but also via the hook.

[SergeyBiryukov]

#47337 was marked as a duplicate.

[SergeyBiryukov]

#49887 was marked as a duplicate.

[SergeyBiryukov]

#56613 was marked as a duplicate.