WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Last modified 3 months ago

#38643 new enhancement

Show toolbar in the user's locale

Reported by: swissspidy's profile swissspidy Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.7
Component: Toolbar Keywords: has-patch needs-refresh changes-requested
Focuses: Cc:

Description

After #29783 and #26511 it might make sense to show the toolbar on the front-end in the user's locale, while keeping the rest of the site in the site's locale.

#29783 actually has a proof-of-concept for that. Screenshot: ​https://twitter.com/swissspidy/status/773571032963751936

Attachments (2)

38643.diff​ (2.0 KB) - added by swissspidy 7 years ago.
38643.WIP.diff​ (2.0 KB) - added by sabernhardt 23 months ago.

Download all attachments as: .zip

Change History (14)

@swissspidy
7 years ago

#1 @swissspidy
7 years ago

  • Keywords has-patch added

38643.diff​ should do the trick. Post type labels need to be fixed first though. See discussion at #26511 for this.

#2 @swissspidy
6 years ago

#39068 was marked as a duplicate.

#3 @swissspidy
6 years ago

#38218 is a possible solution for the post type labels.

#4 @swissspidy
5 years ago

  • Milestone changed from Awaiting Review to Future Release

#5 @swissspidy
4 years ago

This relies on #41305 being fixed first.

#6 @SergeyBiryukov
4 years ago

#46759 was marked as a duplicate.

#7 @sabernhardt
2 years ago

#51654 was marked as a duplicate.

#9 @SergeyBiryukov
2 years ago

#53442 was marked as a duplicate.

@sabernhardt
23 months ago

#10 @sabernhardt
23 months ago

I refreshed the previous patch against trunk, and it still needs some work.

Of course, it does not include the lazily evaluated translations (#41305).

Also, the toolbar container should have language attributes when the profile language does not match the page (whether that is in the site default or a third language).

#11 @ocean90
22 months ago

#53794 was marked as a duplicate.

#12 @sebastienserre
6 months ago

  • Keywords needs-refresh changes-requested added

This ticket was mentioned in ​Slack in #core-i18n by sabernhardt. ​View the logs.
3 months ago

Note: See TracTickets for help on using tickets.