Make WordPress Core

Opened 8 years ago

Last modified 7 weeks ago

#38643 accepted enhancement

Show toolbar (admin bar) in the user's locale (language)

Reported by: swissspidy's profile swissspidy Owned by: pbearne's profile pbearne
Milestone: 6.7 Priority: normal
Severity: normal Version: 4.7
Component: Toolbar Keywords: has-patch changes-requested
Focuses: Cc:

Description

After #29783 and #26511 it might make sense to show the toolbar on the front-end in the user's locale, while keeping the rest of the site in the site's locale.

#29783 actually has a proof-of-concept for that. Screenshot: https://twitter.com/swissspidy/status/773571032963751936

Attachments (2)

38643.diff (2.0 KB) - added by swissspidy 8 years ago.
38643.WIP.diff (2.0 KB) - added by sabernhardt 3 years ago.

Download all attachments as: .zip

Change History (20)

@swissspidy
8 years ago

#1 @swissspidy
8 years ago

  • Keywords has-patch added

38643.diff should do the trick. Post type labels need to be fixed first though. See discussion at #26511 for this.

#2 @swissspidy
8 years ago

#39068 was marked as a duplicate.

#3 @swissspidy
8 years ago

#38218 is a possible solution for the post type labels.

#4 @swissspidy
6 years ago

  • Milestone changed from Awaiting Review to Future Release

#5 @swissspidy
5 years ago

This relies on #41305 being fixed first.

#6 @SergeyBiryukov
5 years ago

#46759 was marked as a duplicate.

#7 @sabernhardt
4 years ago

#51654 was marked as a duplicate.

#9 @SergeyBiryukov
3 years ago

#53442 was marked as a duplicate.

#10 @sabernhardt
3 years ago

I refreshed the previous patch against trunk, and it still needs some work.

Of course, it does not include the lazily evaluated translations (#41305).

Also, the toolbar container should have language attributes when the profile language does not match the page (whether that is in the site default or a third language).

#11 @ocean90
3 years ago

#53794 was marked as a duplicate.

#12 @sebastienserre
22 months ago

  • Keywords needs-refresh changes-requested added

This ticket was mentioned in Slack in #core-i18n by sabernhardt. View the logs.


19 months ago

#14 @johnbillion
7 months ago

#60627 was marked as a duplicate.

#15 @oglekler
7 months ago

  • Summary changed from Show toolbar in the user's locale to Show toolbar (admin bar) in the user's locale (language)

I am changing the Summary to make it easier to find this ticket. I believe that this is called Admin bar, so I didn't search for a toolbar

This ticket was mentioned in PR #7077 on WordPress/wordpress-develop by @pbearne.


7 weeks ago
#16

  • Keywords needs-refresh removed

Updated the admin bar styles in WordPress, adding a function to automatically set the text direction based on the user's locale. This helps ensure correct rendering of the admin bar for right-to-left languages. The function also restores the previous locale after rendering the admin bar.

#17 @pbearne
7 weeks ago

  • Owner set to pbearne
  • Status changed from new to accepted

refreshed

not sure how to test this :-)

#18 @pbearne
7 weeks ago

  • Milestone changed from Future Release to 6.7

@swissspidy commented on PR #7077:


7 weeks ago
#19

The issue with post type labels being in the wrong locale is still unsolved

Note: See TracTickets for help on using tickets.