WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 3 months ago

Last modified 3 months ago

#46408 closed defect (bug) (fixed)

About: Use $display_version in headings

Reported by: mukesh27 Owned by: SergeyBiryukov
Milestone: 5.2.1 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch commit i18n-change
Focuses: Cc:

Description (last modified by SergeyBiryukov)

As per [44733] about.php page changeset we have to remove $display_version as it was no longer in used in below statement.

<p class="about-text"><?php printf( __( 'Thank you for updating to the latest version!' ), $display_version ); ?></p>

Replace to

<p class="about-text"><?php _e( 'Thank you for updating to the latest version!' ); ?></p>

Attachments (4)

46408.diff (646 bytes) - added by mukesh27 6 months ago.
Patch.
46408.2.diff (2.2 KB) - added by desrosj 3 months ago.
46408.3.diff (57.5 KB) - added by desrosj 3 months ago.
46408.4.diff (2.2 KB) - added by desrosj 3 months ago.

Download all attachments as: .zip

Change History (17)

@mukesh27
6 months ago

Patch.

#1 @SergeyBiryukov
5 months ago

  • Description modified (diff)

#2 @SergeyBiryukov
4 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core by sergey. View the logs.


3 months ago

#4 @SergeyBiryukov
3 months ago

  • Keywords needs-refresh added
  • Milestone changed from 5.3 to 5.2.1

Since [45271] and [45292], the tagline contains a hardcoded WordPress 5.2 version.

Per Slack discussion, we should restore WordPress %s here to include minor versions.

@desrosj
3 months ago

#5 @desrosj
3 months ago

  • Keywords needs-refresh removed

46408.2.diff restores the placeholder for $display_version.

#6 @ocean90
3 months ago

#47241 was marked as a duplicate.

@desrosj
3 months ago

#7 @desrosj
3 months ago

46408.3.diff adds translator comments.

#8 @desrosj
3 months ago

  • Summary changed from About: Remove unused $display_version to About: Use $display_version in headings

@desrosj
3 months ago

#9 @desrosj
3 months ago

  • Keywords commit added

I accidentally included some package-lock.json differences in 46408.3.diff. 46408.4.diff removes those.

I think this is good to go. Marking commit pending a second set of eyes from @SergeyBiryukov.

#10 @desrosj
3 months ago

  • Type changed from enhancement to defect (bug)

#11 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45338:

Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.

Props desrosj, mukesh27.
Fixes #46408.

#12 @SergeyBiryukov
3 months ago

In 45339:

Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.

Props desrosj, mukesh27.
Merges [45338] to the 5.2 branch.
Fixes #46408.

#13 @ocean90
3 months ago

  • Keywords i18n-change added
Note: See TracTickets for help on using tickets.