#46408 closed defect (bug) (fixed)
About: Use $display_version in headings
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.2.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Help/About | Keywords: | has-patch commit i18n-change |
Focuses: | Cc: |
Description (last modified by )
As per [44733] about.php page changeset we have to remove $display_version
as it was no longer in used in below statement.
<p class="about-text"><?php printf( __( 'Thank you for updating to the latest version!' ), $display_version ); ?></p>
Replace to
<p class="about-text"><?php _e( 'Thank you for updating to the latest version!' ); ?></p>
Attachments (4)
Change History (18)
#2
@
4 years ago
- Milestone changed from Awaiting Review to 5.3
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
This ticket was mentioned in Slack in #core by sergey. View the logs.
4 years ago
#4
@
4 years ago
- Keywords needs-refresh added
- Milestone changed from 5.3 to 5.2.1
Since [45271] and [45292], the tagline contains a hardcoded WordPress 5.2
version.
Per Slack discussion, we should restore WordPress %s
here to include minor versions.
#5
@
4 years ago
- Keywords needs-refresh removed
46408.2.diff restores the placeholder for $display_version
.
#7
@
4 years ago
46408.3.diff adds translator comments.
#8
@
4 years ago
- Summary changed from About: Remove unused $display_version to About: Use $display_version in headings
#9
@
4 years ago
- Keywords commit added
I accidentally included some package-lock.json
differences in 46408.3.diff. 46408.4.diff removes those.
I think this is good to go. Marking commit
pending a second set of eyes from @SergeyBiryukov.
Note: See
TracTickets for help on using
tickets.
Patch.