Nav Menus: Delete Menu action link is misaligned in responsive view

[ianbelanger]

When adjusting line heights to unitless values, I noticed that the Delete Menu action link on the Menus page is misaligned when the screen is under 782px. Screenshot and patch coming

[ianbelanger]

Before applying patch

[ianbelanger]

adds padding-top: 1em; to delete menu action

[ianbelanger]

After applying patch

[audrasjb]

Hi,
Thanks for the patch, I'll get this one reviewed soon :-)

[audrasjb]

I tested 47173.diff, it applies well and it fixed the issue on my side.
This should be fixed in 5.2.1 since it's a regression coming from 5.2.

Thanks @ianbelanger :-)

[ianbelanger]

Thanks @audrasjb, although I don't think that this issue was introduced in 5.2. I am seeing it in 5.1.1 as well, but it wouldn't hurt to get it in 5.2.1. Thanks for the quick review!

[mukesh27]

@ianbelanger instead of adding top padding can we remove top padding from publish button? check attached screenshot after remove padding from publish button.

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/nav-menus.css#L838

.nav-menus-php .major-publishing-actions .publishing-action {
	padding-top: 1em;
}

[garrett-eclipse]

Thanks @ianbelanger reviewing the patch and screenshot @mukesh27 provided I agree removing the top padding provides a nicer presentation as it gives the action a vertical centering in the space with equal padding above/below and to the right of the action. With that in mind going to add a refresh.

[ianbelanger]

Updates patch to remove publishing action top padding

[afercia]

I think this was introduced in WordPress 4.9 see [41197] / #41499.

The top padding should stay for the "Save Menu" at the top of the page but shouldn't target also the "Save Menu" at the bottom.

[desrosj]

This still needs a refresh, and I'd love for it to get some design attention. Going to move it to 5.2.2.

[ianbelanger]

Updates patch to only target top publishing action with the top padding

[ianbelanger]

I was actually working on a fix for this when you changed the milestone @desrosj. Just uploaded the patch to fix the issue. Not sure that we need design-feedback since it is a regression from 4.9, but if someone from design wants to weigh-in that would be great. Going to move back into 5.2.1 milestone and mark for commit.

[ianbelanger]

After applying 47173.2.diff

[desrosj]

The left of my screenshot is 4.8 and the right is with 47173.2.diff​. Since this is a regression, let's get this in.

[desrosj]

In 45324:

Menus: Fix alignment of menu actions on mobile.

In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.

[desrosj]

Reopening for backport.

[desrosj]

In 45325:

Menus: Fix alignment of menu actions on mobile.

In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Merges [45324] to the 5.2 branch.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.