WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 8 weeks ago

Last modified 7 weeks ago

#48101 closed task (blessed) (fixed)

Use darker table + card borders across WP-Admin

Reported by: kjellr Owned by: kjellr
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots has-patch 5-3-admin-css-changes has-dev-note
Focuses: ui, accessibility Cc:
PR Number:

Description

This ticket is a design change to accompany the higher-contrast changes in #47153, #47150, and #34904.

As discussed in make.wordpress.org/design, we should adjust the borders of tables and card elements so that their visual hierarchy is preserved alongside the darker field borders and buttons.

https://make.wordpress.org/design/2019/09/06/discussion-higher-contrast-form-fields-and-buttons/

This patch changes the borders to #ccd0d4 ($light-gray-700).

Effected elements:

  • Table borders
  • Screen meta links / help tabs
  • Notices
  • Welcome panel
  • Postbox
  • Post Status Info
  • Card
  • Health Check accordion + heading
  • Theme + plugin upload forms

I may have missed a spot or two, so please make note of those if you come across anything.

cc @karmatosed, @audrasjb, @melchoyce

Screenshots


Dashboard (Current)

https://cldup.com/lWsKYApss1-3000x3000.png

Dashboard (New)

https://cldup.com/7uJeFtNcWp-3000x3000.png


Plugins Page (Current)

https://cldup.com/e5Ymo1yHUS-3000x3000.png

Plugins Page (New)

https://cldup.com/5FA4YzsJvT-3000x3000.png


Themes Page (Current)

https://cldup.com/-88oohFzVP.png

Themes Page (New)

https://cldup.com/PaMNg642v8-1200x1200.png

Attachments (3)

48101.patch (5.3 KB) - added by kjellr 3 months ago.
Screen Shot 2019-09-21 at 7.39.19 PM.png (1.1 MB) - added by melchoyce 3 months ago.
Screen Shot 2019-09-21 at 7.45.24 PM.png (717.0 KB) - added by melchoyce 3 months ago.

Download all attachments as: .zip

Change History (24)

@kjellr
3 months ago

#1 @pbiron
3 months ago

  • Keywords has-screenshots added

This ticket was mentioned in Slack in #accessibility by kjell. View the logs.


3 months ago

#3 @audrasjb
3 months ago

  • Focuses accessibility added
  • Keywords has-patch commit needs-dev-note added

Reviewed/tested on my side and it's a +1 for me.
Many thanks @kjellr 👍

Adding commit keyword.

#4 @melchoyce
3 months ago

One other quick idea — we could ditch the borders and shadows on the various metaboxes and tables, and preserve borders for elements that need to stand out as interactive, and for elements that would benefit from additional division.

Did you add borders to the notices? I feel like the border looks really weird on those in the "after" version.

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


3 months ago

#6 @afercia
3 months ago

  • Milestone changed from Awaiting Review to 5.3

This ticket is a design change to accompany the higher-contrast changes in #47153, #47150, and #34904.

Setting the milestone to 5.3, consistent with those other tickets.

#7 @kjellr
3 months ago

Did you add borders to the notices? I feel like the border looks really weird on those in the "after" version.

I did. I'm not 100% convinced it's necessary, but the notices definitely receded to the background visually without them. That seemed unfortunate, since by definition, they're supposed to be noticed. 😄

https://cldup.com/KOvLBkiJWu-3000x3000.png

One other quick idea — we could ditch the borders and shadows on the various metaboxes and tables, and preserve borders for elements that need to stand out as interactive, and for elements that would benefit from additional division.

I'm torn on this. I really like the feel of having no borders or drop shadows, but I think removing them really pushes the form fields and buttons forward visually... maybe a little too far? I'll try to get a patch going with this variation to try it out across more screens.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 months ago

#9 @melchoyce
3 months ago

I did. I'm not 100% convinced it's necessary, but the notices definitely receded to the background visually without them. That seemed unfortunate, since by definition, they're supposed to be noticed. 😄

What if we upped the drop shadow instead?

Also — why is the border in that screenshot grey, not green?

#10 @afercia
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 46242:

Accessibility: Improve and modernize user interface controls for better contrast. Second part: tables, meta boxes, and other user interface elements.

Introduces better contrast for borders of the following user interface elements:

  • Tables
  • Screen Options and Help
  • Admin notices
  • Welcome panel
  • Meta boxes (post boxes)
  • Cards
  • Health Check accordions and headings
  • Theme and Plugin upload forms

Props kjellr, melchoyce, karmatosed, audrasjb.
Fixes #48101.

#11 @afercia
3 months ago

  • Keywords commit removed

#12 @kjellr
3 months ago

Also — why is the border in that screenshot grey, not green?

That's my fault — I was messing with CSS in the inspector. Not a problem with the patch. 😅

#13 @drw158
3 months ago

FWIW I don't mind the new border style on the notices. The existing notices look slightly elevated (or has a slight dimension?), like the existing buttons, which seems strange to me because I think of inline notices as being on the same elevation plane as the rest of the UI (0).

Although, I know that there isn't much elevation in WP Admin, so it's not a huge deal.

The border on the notice does look a bit fuzzy in the update. Here is just a simple css border around the whole thing, no box-shadow:

https://cldup.com/wmwIyWfTui.png

Example of something similar: https://evergreen.segment.com/components/alert

I think this would also make the notice more resilient in more places, and not require a gray background to stand out.

Last edited 3 months ago by drw158 (previous) (diff)

#14 @SergeyBiryukov
2 months ago

  • Component changed from General to Administration

This ticket was mentioned in Slack in #accessibility by kjell. View the logs.


2 months ago

#16 @audrasjb
2 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from defect (bug) to task (blessed)

Reopening this ticket as a blessed task to allow us to iterate on the related changes.

Reopened tickets: #47153, #47477, #47498, #48101

#17 @afercia
2 months ago

  • Keywords 5-3-admin-css-changes added

This ticket was mentioned in Slack in #accessibility by audrasjb. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by marybaum. View the logs.


2 months ago

#20 @desrosj
8 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This one looks to have been reopened to allow for further updates, but there are no action items here that I can see. Going to close this out in favor of new tickets for follow up changes.

Note: See TracTickets for help on using tickets.