Make WordPress Core

Opened 5 years ago

Closed 3 years ago

#48939 closed enhancement (fixed)

Consider iterating text on media upload for alt text

Reported by: karmatosed's profile karmatosed Owned by: joedolson's profile joedolson
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: accessibility Cc:

Description

This could be confusing both in what it does and linking to an external source. It might be a good idea to work on some ideas to improve the copy here and also linking.

http://cldup.com/pr-XXP2-rM.png

Attachments (2)

48939.patch (2.2 KB) - added by sabernhardt 3 years ago.
both PHP instances: editing text and replacing link for a potentially localized WordPress.org resource
48939.1.patch (1.5 KB) - added by sabernhardt 3 years ago.
text change only (in both PHP files)

Download all attachments as: .zip

Change History (23)

#1 @karmatosed
5 years ago

  • Keywords needs-design-feedback added

#2 @melchoyce
5 years ago

Historical context in #41612

This ticket was mentioned in Slack in #design by estelaris. View the logs.


4 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#5 @afercia
4 years ago

  • Focuses accessibility added

#6 @hellofromTonya
4 years ago

#51616 was marked as a duplicate.

#7 @hellofromTonya
4 years ago

Merging @garrett-eclipse description from a duplicate ticket #51616:

On Media Modals the Alt Text has a description containing a link 'Describe the purpose of the image.' that's a little misleading to new users. It feels less a description and information and more an action in that users click it thinking that's how one would describe the image but instead find it's just information.

Could a little (i) icon be added to denote it as informational. Or could we adjust the language;
_Alt Text_ describes the image purpose.
*Where just the 'Alt Text' part is links.
This i feel would take the link off the action word which is what currently makes the link feel like an action and not just extra information.

Love the concept of the feature just think we can remove the ambiguity of the link purpose.

#8 @afercia
4 years ago

Linking to the related issue and PR on the Gutenberg repo:
https://github.com/WordPress/gutenberg/issues/19068
https://github.com/WordPress/gutenberg/pull/26520

The key concepts the accessibility team want to communicate with this text and that were discussed on #41612 and related conversations on Slack are the the following 3 ones:

  • The alt text describes the purpose of the image, it's not the image description. The image purpose can be very different from the image content depending on usage and context.
  • The link points to a resource that explains this concept in detail: the W3C "alt decision tree"
  • In most of the cases, images are purely decorative and don't need an alt text. The part "Leave empty if the image is purely decorative" is fundamental to communicate this concept to users as they tend to think they have to provide an alt text in all cases (which is wrong)

Improvements to the current text are welcome as long as these three points are cleaerly communicated. Proposal with minimal change:

[link]Learn how to describe the purpose of the imagelink. Leave empty if the image is purely decorative.

This ticket was mentioned in Slack in #accessibility by alexstine. View the logs.


4 years ago

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


3 years ago

#11 @joedolson
3 years ago

  • Keywords needs-patch added; needs-design-feedback removed
  • Milestone changed from Awaiting Review to 5.9
  • Owner set to joedolson
  • Status changed from new to accepted
  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


3 years ago

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


3 years ago

@sabernhardt
3 years ago

both PHP instances: editing text and replacing link for a potentially localized WordPress.org resource

#15 @sabernhardt
3 years ago

  • Keywords has-patch added; needs-patch removed

GB19068 mentions using a WordPress.org resource for the tutorial, and I chose the Accessibility Handbook page. That includes links to the decision tree.

The patch also uses an internationalization function for the link. A support article may be easier to translate, if we could find or add one.

Of course, the block editor change(s) would need a separate patch/PR.

This ticket was mentioned in Slack in #core-media by joedolson. View the logs.


3 years ago

#17 @antpb
3 years ago

Noting from the Media meeting discussion on this, it was generally agreed that this patch should point to the existing W3C url and not a WordPress.org url.

With that change made this text enhancement should be good to go.

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


3 years ago

@sabernhardt
3 years ago

text change only (in both PHP files)

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


3 years ago

This ticket was mentioned in PR #1824 on WordPress/wordpress-develop by antpb.


3 years ago
#20

<!-Trac ticket:
https://core.trac.wordpress.org/ticket/48939

String changes sometimes break in tests so just being extra certain we're good there. :)

#21 @antpb
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52033:

Media: Adjust alt text info link text.

Previous messaging of this link was confusing given it went to an external source. This change describes more accurately that it will perform the action of taking you to the resource.

Props karmatosed, joedolson, melchoyce, hellofromTonya, afercia, sabernhardt, antpb.
Fixes #48939.

Note: See TracTickets for help on using tickets.