WordPress.org

Make WordPress Core

Opened 8 weeks ago

Last modified 8 weeks ago

#49768 assigned defect (bug)

Update/Audit NPM dependencies for 5.5

Reported by: whyisjake Owned by: whyisjake
Milestone: 5.5 Priority: normal
Severity: normal Version: trunk
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Carrying some of the work out of #49547, we were able to push some upstream dependencies to update.

Attachments (2)

49768.diff (25.1 KB) - added by whyisjake 8 weeks ago.
49768.2.diff (44.4 KB) - added by SergeyBiryukov 8 weeks ago.

Download all attachments as: .zip

Change History (6)

#1 @whyisjake
8 weeks ago

  • Owner set to whyisjake
  • Status changed from new to assigned

@whyisjake
8 weeks ago

#2 @SergeyBiryukov
8 weeks ago

#49707 was marked as a duplicate.

This ticket was mentioned in PR #212 on WordPress/wordpress-develop by whyisjake.


8 weeks ago

Dependency bump coming out of a security audit.

Trac ticket: https://core.trac.wordpress.org/ticket/49768

#4 @SergeyBiryukov
8 weeks ago

  • Keywords has-patch added

With grunt-contrib-qunit bumped to 3.1.0 and now requiring puppeteer, PUPPETEER_SKIP_CHROMIUM_DOWNLOAD apparently needs to be reset for JS tests to pass, otherwise they produce a fatal error as seen in this build:

>> There was an error with headless chrome
Fatal error: Chromium revision is not downloaded. Run "npm install" or "yarn install"

49768.2.diff handles that, and also keeps tilde and caret ranges for grunt, grunt-contrib-imagemin, and grunt-contrib-qunit versions in package.json.

Note: See TracTickets for help on using tickets.