WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 7 weeks ago

#50577 closed enhancement (fixed)

Use wp.i18n for translatable strings in wp-admin/js/tags.js

Reported by: ocean90 Owned by: ocean90
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-dev-note
Focuses: javascript Cc:

Description

We should replace the use of wp_localize_script() with the proper JavaScript i18n functions introduced in WordPress 5.0, see #20491 and #45103. This ticket is for wp-admin/js/tags.js.

Related tickets:

#50235
Use wp.i18n for translatable strings in wp-admin/js/updates.js
#50525
Use wp.i18n for translatable strings in wp-includes/js/wp-pointer.js
#50526
Use wp.i18n for translatable strings in wp-admin/js/common.js
#50527
Use wp.i18n for translatable strings in wp-admin/js/user-profile.js
#50535
Use wp.i18n for translatable strings in wp-admin/js/privacy-tools.js
#50553
Use wp.i18n for translatable strings in wp-includes/js/wp-auth-check.js
#50576
Use wp.i18n for translatable strings in wp-admin/js/theme-plugin-editor.js
#50577
Use wp.i18n for translatable strings in wp-admin/js/tags.js
#50578
Use wp.i18n for translatable strings in wp-admin/js/edit-comments.js
#50579
Use wp.i18n for translatable strings in wp-admin/js/tags-box.js and wp-admin/js/tags-suggest.js
#50596
Use wp.i18n for translatable strings in wp-admin/js/color-picker.js
#50597
Use wp.i18n for translatable strings in wp-admin/js/media.js
#50599
Use wp.i18n for translatable strings in wp-admin/js/post.js
#50600
Use wp.i18n for translatable strings in wp-admin/js/widgets.js
#50601
Use wp.i18n for translatable strings in wp-admin/js/inline-edit-post.js and wp-admin/js/inline-edit-tax.js
#50602
Use wp.i18n for translatable strings in wp-admin/js/plugin-install.js
#50603
Use wp.i18n for translatable strings in wp-admin/js/nav-menu.js
#50604
Use wp.i18n for translatable strings in wp-admin/js/comment.js
#50605
Use wp.i18n for translatable strings in wp-admin/js/set-post-thumbnail.js


Change History (4)

#1 @ocean90
3 months ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 48347:

I18N: Use wp.i18n for translatable strings in wp-admin/js/tags.js.

This removes the usage of wp_localize_script() for passing translations to the script and instead adds the translatable strings in the script directly through the use of wp.i18n and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50577.

#2 @TobiasBg
3 months ago

Doesn't this need an added wp in the global definition in line 10?

#3 @justinahinon
8 weeks ago

  • Keywords needs-dev-note added
Note: See TracTickets for help on using tickets.