#52658 closed defect (bug) (fixed)
Expand the "Verify NPM" workflow
Reported by: | desrosj | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch fixed-major |
Focuses: | Cc: |
Description
The verify-npm-on-windows.yml
workflow verifies that NPM successfully installs and can successfully build WordPress on Windows environments.
When #51734 is merged, npm run build
will no longer be run as part of the PHPUnit test workflow. While it still will run for QUnit tests, it would be beneficial to have a job that explicitly verifies npm install
/npm run build
passes for Linux. MacOS could also be added.
Additionally, other NPM scripts could be tested, such as build:dev
, and the grunt clean
commands once #52657 is committed.
Change History (28)
This ticket was mentioned in PR #1049 on WordPress/wordpress-develop by desrosj.
4 years ago
#1
- Keywords has-patch added; needs-patch removed
codecov[bot] commented on PR #1049:
4 years ago
#2
# Codecov Report
Merging #1049 (33af393) into master (4a09e7d) will decrease coverage by
2.45%
.
The diff coverage isn/a
.
{{{diff
@@ Coverage Diff @@
## master #1049 +/- ##
============================================
- Coverage 45.68% 43.23% -2.46% Complexity 15621 15621
============================================
Files 558 558
Lines 111373 111373
============================================
- Hits 50880 48151 -2729
- Misses 60493 63222 +2729
}}}
| Flag | Coverage Δ | Complexity Δ | |
| multisite | ?
| ?
| |
| php | 43.23% <ø> (-2.46%)
| 0.00 <ø> (ø)
| |
| single | 43.23% <ø> (ø)
| 0.00 <ø> (ø)
| |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | Complexity Δ | |
| src/wp-admin/includes/template.php | 23.00% <ø> (ø)
| 0.00 <0.00> (ø)
| |
| src/wp-includes/ms-site.php | 0.00% <0.00%> (-91.97%)
| 0.00% <0.00%> (ø%)
| |
| src/wp-includes/ms-network.php | 0.00% <0.00%> (-89.66%)
| 0.00% <0.00%> (ø%)
| |
| src/wp-includes/class-wp-site.php | 0.00% <0.00%> (-81.49%)
| 34.00% <0.00%> (ø%)
| |
| src/wp-includes/class-wp-network-query.php | 0.00% <0.00%> (-78.40%)
| 64.00% <0.00%> (ø%)
| |
| src/wp-includes/class-wp-site-query.php | 0.00% <0.00%> (-78.39%)
| 100.00% <0.00%> (ø%)
| |
| src/wp-includes/class-wp-network.php | 0.00% <0.00%> (-70.59%)
| 58.00% <0.00%> (ø%)
| |
| src/wp-includes/ms-blogs.php | 0.00% <0.00%> (-69.79%)
| 0.00% <0.00%> (ø%)
| |
| src/wp-includes/ms-functions.php | 0.00% <0.00%> (-40.21%)
| 0.00% <0.00%> (ø%)
| |
| src/wp-admin/includes/schema.php | 49.71% <0.00%> (-35.57%)
| 0.00% <0.00%> (ø%)
| |
| ... and 37 more | |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dae8858...f24ffb5. Read the comment docs.
#4
@
4 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to backport.
4 years ago
#5
Merged into Core in https://core.trac.wordpress.org/changeset/50485.
Trac ticket: https://core.trac.wordpress.org/ticket/52658.
This generalizes the verify NPM workflow and adds testing for Linux and MacOS.