Opened 5 years ago
Last modified 4 years ago
#54621 assigned defect (bug)
Unsaved comment warning without any changes made when click on Publish, Update or Preview Buttons
| Reported by: | askaryabbas | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Comments | Version: | 4.6 |
| Severity: | major | Keywords: | needs-patch reporter-feedback |
| Cc: | Focuses: | javascript, administration |
Description
Hi Team,
I got unsaved comment changes warning without any changes made in the content of the custom post type post, here is screenshot: https://i.imgur.com/PQmirDL.png
I see new codes are added in the WordPress core file: wp-admin/js/edit-comments.js And there is some condition issue, the code is have strict equality comparison operator to undefined ID which is not present in the custom post type: #replyrow
Screenshot: https://i.imgur.com/kAHNkrs.png
Please review it.
Thanks
Attachments (1)
Change History (7)
#1
follow-up:
↓ 2
@
5 years ago
- Keywords needs-patch added
- Milestone Awaiting Review → 6.0
- Version 5.8.2 → 4.6
#2
in reply to: ↑ 1
@
5 years ago
Replying to SergeyBiryukov: Thanks @SergeyBiryukov
Hi there, welcome back to WordPress Trac! Thanks for the report.
Moving to 6.0 for investigation. The code in question was introduced in [37303] / #32818, changing the version accordingly.
Also removing the
coding-standardsfocus, as even though this appears to be a valid issue, it doesn't seem related to the WordPress PHP or JS coding standards.
#3
@
5 years ago
- Focuses coding-standards removed
- Keywords reporter-feedback added
@askaryabbas I looked into this, and I wasn't able to replicate this specific issue on a CPT, but I was able to find a related issue. I filed a separate ticket for it, as its scope is a bit larger, and may not completely resolve the issue on a CPT.
Can you go through the steps to reproduce this on a custom post type? Did you click on "Reply" on any of the comments before clicking "Update" on your post?
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Hi there, welcome back to WordPress Trac! Thanks for the report.
Moving to 6.0 for investigation. The code in question was introduced in [37303] / #32818, changing the version accordingly.
Also removing the
coding-standardsfocus, as even though this appears to be a valid issue, it doesn't seem related to the WordPress PHP or JS coding standards.