WordPress.org
Get WordPress

Make WordPress Core

Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#56867 closed defect (bug) (fixed)

Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php

Reported by: rakibwordpress's profile rakibwordpress Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version: 6.1
Component: Pings/Trackbacks Keywords: has-patch changes-requested
Focuses: docs Cc:

Description

This function (trackback_response) takes $error_message parameter and by default it is null and this is not mentioned on the inline doc.

Change History (9)

This ticket was mentioned in ​PR #3504 on ​WordPress/wordpress-develop by ​@rakibwordpress.
23 months ago #1

…on wp-trackback.php

Trac ticket:

#2 @SergeyBiryukov
23 months ago

  • Component changed from Editor to Pings/Trackbacks
  • Milestone changed from Awaiting Review to 6.2

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

It looks like it should be Default empty string though, rather than null.

#3 @rakibwordpress
23 months ago

Yes. Empty string is more correct.

#4 @audrasjb
23 months ago

  • Keywords changes-requested added

Hello, thanks for the patch. I requested some changes :)

Thank you!

#5 @rakibwordpress
23 months ago

Hi, I have updated as per request.

#6 @audrasjb
23 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 54656:

Docs: Add missing default parameter value in trackback_response() docblock.

Props rakibwordpress, audrasjb, SergeyBiryukov.
Fixes #56867.
See #56792.

#8 @jorbin
23 months ago

In 54657:

Revert accidental 5.9 branch commits [54655] and [54656]

Unprops audrasjb.
See #56867, #56792, #56862, #56792.

#9 @jorbin
23 months ago

In 54658:

Docs: Add missing default parameter value in trackback_response() docblock.

Previously: [54656] [54657]

Props rakibwordpress, audrasjb, SergeyBiryukov.
Fixes #56867.
See #56792.

Note: See TracTickets for help on using tickets.