WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#56867 closed defect (bug) (fixed)

Docs: Default parameter not mentioned on trackback_response function on wp-trackback.php

Reported by: rakibwordpress Owned by: audrasjb
Priority: normal Milestone: 6.2
Component: Pings/Trackbacks Version: 6.1
Severity: normal Keywords: has-patch changes-requested
Cc: Focuses: docs

Description

This function (trackback_response) takes $error_message parameter and by default it is null and this is not mentioned on the inline doc.

Change History (9)

This ticket was mentioned in ​PR #3504 on ​WordPress/wordpress-develop by ​@rakibwordpress.
4 years ago #1

…on wp-trackback.php

Trac ticket:

#2 @SergeyBiryukov
4 years ago

  • Component Editor → Pings/Trackbacks
  • Milestone Awaiting Review → 6.2

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

It looks like it should be Default empty string though, rather than null.

#3 @rakibwordpress
4 years ago

Yes. Empty string is more correct.

#4 @audrasjb
4 years ago

  • Keywords changes-requested added

Hello, thanks for the patch. I requested some changes :)

Thank you!

#5 @rakibwordpress
4 years ago

Hi, I have updated as per request.

#6 @audrasjb
4 years ago

  • Owner set to audrasjb
  • Resolution → fixed
  • Status new → closed

In 54656:

Docs: Add missing default parameter value in trackback_response() docblock.

Props rakibwordpress, audrasjb, SergeyBiryukov.
Fixes #56867.
See #56792.

#8 @jorbin
4 years ago

In 54657:

Revert accidental 5.9 branch commits [54655] and [54656]

Unprops audrasjb.
See #56867, #56792, #56862, #56792.

#9 @jorbin
4 years ago

In 54658:

Docs: Add missing default parameter value in trackback_response() docblock.

Previously: [54656] [54657]

Props rakibwordpress, audrasjb, SergeyBiryukov.
Fixes #56867.
See #56792.

Note: See TracTickets for help on using tickets.