Make WordPress Core

Opened 8 weeks ago

Last modified 3 weeks ago

#60901 reopened defect (bug)

GitHub Actions: Migrate to Docker Compose v2

Reported by: swissspidy's profile swissspidy Owned by: swissspidy's profile swissspidy
Milestone: 6.5.4 Priority: high
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch fixed-major
Focuses: Cc:

Description

Right now a lot of our GitHub Actions workflows are failing.

The reason is that GitHub started removing Docker Compose v1 and the rollout is taking a few days.

Docker Compose v2 was released years ago and the migration should be pretty straightforward.

The main difference is that docker-compose is no longer a valid command. You need to use docker compose.

Change History (19)

This ticket was mentioned in PR #6349 on WordPress/wordpress-develop by @swissspidy.


8 weeks ago
#1

  • Keywords has-patch added

@swissspidy commented on PR #6349:


8 weeks ago
#2

The current test failures all seem to be related to 502 Bad Gateway errors on WordPress.org.

@swissspidy commented on PR #6349:


8 weeks ago
#3

Some of the PHPUnit test failures are because the workflow uses the phpunit-tests-run.yml file from trunk, which doesn't yet have this fix.

This will be resolved when committing this change to trunk.

Same with the performance tests failures, which check out the previous commit which of course still uses docker-compose.

#4 @swissspidy
8 weeks ago

  • Milestone changed from Awaiting Review to 6.5.1

Moving to 6.5.1 as we probably need to backport this to all the older branches.

#5 @swissspidy
8 weeks ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 57918:

Build/Test Tools: Migrate to Docker Compose V2.

Compose V2, which was first released in 2020, is included with all currently supported versions of Docker Desktop. Compose V1 stopped receiving updates in July 2023.

The biggest difference is that the command to interact with Compose changed from docker-compose to docker compose.

GitHub has now started removing V1 from Ubuntu & Windows images, which caused all Docker-based GitHub Actions workflows to fail.

This change migrates to the new docker compose command to address these failures.

Props swissspidy, thelovekesh.
Fixes #60901.

@swissspidy commented on PR #6349:


8 weeks ago
#6

Committed in https://core.trac.wordpress.org/changeset/57918

There will likely be some follow-up commits though.

#7 @swissspidy
8 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#8 @johnbillion
8 weeks ago

  • Keywords fixed-major added

This ticket was mentioned in Slack in #core by jorbin. View the logs.


7 weeks ago

#10 @desrosj
7 weeks ago

In 57927:

Build/Test Tools: Migrate to Docker Compose V2.

Compose V2, which was first released in 2020, is included with all currently supported versions of Docker Desktop. Compose V1 stopped receiving updates in July 2023.

The biggest difference is that the command to interact with Compose changed from docker-compose to docker compose.

GitHub has now started removing V1 from Ubuntu & Windows images, which caused all Docker-based GitHub Actions workflows to fail.

This change migrates to the new docker compose command to address these failures.

Merges [57918] to the 6.5 branch.

Props swissspidy, thelovekesh.
See #60901.

#11 @desrosj
7 weeks ago

Per today's bug scrub, [57927] merged [57918] to the 6.5 branch to ensure this problem will not hold up any work on 6.5.1. Older branches will be explored during April.

#12 @davidbaumwald
7 weeks ago

  • Milestone changed from 6.5.1 to 6.5.2

Milestone renamed

#13 @jorbin
7 weeks ago

  • Milestone changed from 6.5.2 to 6.5.3

This ticket was mentioned in Slack in #core by jorbin. View the logs.


5 weeks ago

This ticket was mentioned in Slack in #core by jorbin. View the logs.


5 weeks ago

#16 @swissspidy
4 weeks ago

@desrosj Any thoughts on the older branches?

#17 @desrosj
4 weeks ago

This is blocked by #60822.

I'm also seeing some warnings locally. I don't think that they're related to [57918], though. I just wanted to mention them here in case anyone else noticed these.

WARNING: Plugin "/Users/username/.docker/cli-plugins/docker-scan" is not valid: failed to fetch metadata: fork/exec /Users/username/.docker/cli-plugins/docker-scan: no such file or directory
WARNING: daemon is not using the default seccomp profile
WARN[0000] /Users/username/Sites/wordpress-svn/six-two/docker-compose.yml: `version` is obsolete

For docker scan, this was archived in favor of docker scout. I fixed this by navigating to the ~/.docker/cli-plugins folder and manually deleting the docker-scan alias. The source file had been properly deleted, but for some reason the alias remained and Docker was trying to use it.

I haven't figured out how to fix the seccomp warning. And I opened #61101 for the fourth one.

I think we could probably backport this, #60822, and #61101 at the same time.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


4 weeks ago

#19 @jorbin
3 weeks ago

  • Milestone changed from 6.5.3 to 6.5.4
Note: See TracTickets for help on using tickets.