WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 months ago

#14157 new enhancement

wp-includes references should be wiped off

Reported by: steak Owned by:
Milestone: Future Release Priority: lowest
Severity: minor Version:
Component: Bootstrap/Load Keywords: has-patch needs-testing dev-feedback gsoc
Focuses: Cc:

Description

I think all references to wp-includes should be wiped off and use the WPINC WP constant. This may allow for a future renaming of the wp-includes folder if needed.

E.g in script-loader.php:

$scripts->add( 'jquery-ui-core', '/wp-includes/js/jquery/ui.core.js', array('jquery'), '1.7.1' );

To:

$scripts->add( 'jquery-ui-core', '/' . WPINC. '/js/jquery/ui.core.js', array('jquery'), '1.7.1' );

Attachments (1)

14157.diff (45.7 KB) - added by wojtek.szkutnik 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 steak4 years ago

  • Summary changed from wp-include references should be wiped off to wp-includes references should be wiped off

comment:2 scribu4 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to lowest

comment:3 scribu4 years ago

  • Keywords needs-patch added; wp-includes WPINC removed

wojtek.szkutnik4 years ago

comment:4 wojtek.szkutnik4 years ago

  • Cc wojtek.szkutnik@… added
  • Keywords has-patch needs-testing dev-feedback added; needs-patch removed

Patch attached. Although, I have a few questions:
wp-admin/includes/update-core.php - it is unclear to me, if the wp-includes references should stay or not

wp-admin/network.php and wp-includes/rewrite.php I need strong testing and feedback on these rewrites, can anyone confirm it works as expected?

wp-includes/js/thickbox/thickbox.js two references to wp-includes in a js file, how can these two be handled?

comment:5 wojtek.szkutnik4 years ago

  • Keywords gsoc added

comment:6 anantshri3 years ago

  • Cc anantshri added

Hi This should be done.... if no one is working on it i can try creating a patch, as per my initail scan of the whole folder structure only 1-2 files can have some problem other then that all could be modified.

will start working if no objection is recieved.

comment:7 nacin3 months ago

  • Component changed from General to Bootstrap/Load
Note: See TracTickets for help on using tickets.