WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#27642 closed defect (bug) (fixed)

Keyboard Accessibility for TinyMCE image panel

Reported by: joedolson Owned by: azaozz
Milestone: 4.1 Priority: normal
Severity: normal Version: 3.9
Component: TinyMCE Keywords:
Focuses: accessibility Cc:

Description

Related: #24409

There is no way to access the controls for modifying image insertion characteristics from the keyboard, and therefore also for screen readers.

Once the TinyMCE Edit Image panel is opened, keyboard and screen reader access is almost perfect, with the exception that a) the user can tab out of the modal and b) the 'Close' button is not included in the tab focus order. The modal should also be closable using the Esc key. These are relatively minor issues.

The greater issue is whether it's possible to access the modal from the keyboard, which means making the controls for the image keyboard focusable.

This issue also references tickets #25100, #25101, #25102, #25103 and #25105; with the add media panel issues at present, it's not possible to insert an image at all unless you're sighted and using a mouse.

Attachments (1)

Screen Shot 2014-05-29 at 10.42.03 AM.png (276.4 KB) - added by helen 5 years ago.

Download all attachments as: .zip

Change History (24)

#1 @joedolson
5 years ago

  • Keywords needs-patch added

#2 @helen
5 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 4.0

Attached a screenshot above - this modal shifted a fair bit toward the end of 3.9 development, so it may not be the same as it was. Testing now, tabbing seems to be contained and esc closes it. Can you re-test for what issues remain or are new? I can't seem to use the keyboard to action into this view at all, actually, but it's possible I'm missing something.

#3 @joedolson
5 years ago

The close button is now in tab order, but it's textless, so it would just be read as a blank link by screen readers; it should have screen-reader-text to provide a label for screen readers. ESC works to close.

I'm not seeing that the tab order is contained; I can still tab out of the modal (Chrome current).

And yes, there's still no way to trigger the modal from the keyboard.

I can select the image, by moving the cursor before it and using shift right-arrow to select, and that triggers the resize points, but doesn't give me any keyboard access that I can find.

This ticket was mentioned in IRC in #wordpress-ui by helen. View the logs.


5 years ago

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


5 years ago

#6 @DrewAPicture
5 years ago

  • Milestone changed from 4.0 to Future Release

helen: "can't get to that modal by keyboard alone right now."

Also, no patch. Punting for now.

This ticket was mentioned in IRC in #wordpress-ui by _Redd. View the logs.


5 years ago

#8 @joedolson
5 years ago

At the moment, the root issue on this ticket is still very important: there's no way to add captions using a keyboard. This is because the only path to add subtitles/captions is by opening this media modal, which can only be done by clicking on the visual editor image insert for a video.

I'm open to raising that as a new ticket or by revising this one, but recommend against closing this ticket.

#9 @joedolson
5 years ago

  • Keywords reporter-feedback removed

#10 follow-up: @rianrietveld
5 years ago

This issue still exists in WP 4.1 beta 1 with the new .

In the WYSIWYG editor there is now way, after selecting an image, to enter the options to edit the Image Details panel using a keyboard or screen reader only. Also the options to align an image are unreachable.
Also NVDA doesn't give any indication that there is a way to enter alignment options or edit the image.

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


5 years ago

#12 @afercia
5 years ago

Basically this issue still applies to the new TinyMCE "image toolbar", see #30147 which is not usable with the keyboard. For image alignment, there are some keyboard shortcuts:

  • Alt+Shift+L align left
  • Alt+Shift+C align center
  • Alt+Shift+R align right

though I doubt users are informed about them.

The real issue is editing the image details (alt text, caption, size, advanced options): once an image is inserted into the editor, mouse users can simply select it and click on the "pencil" icon, keyboard users have no options.

#13 follow-up: @joedolson
5 years ago

One of my biggest concerns about this actually pertains to videos and video captions; right now, the *only* way to add captions to a video within WordPress core is by clicking on the media toolbar in the visual editor after adding a video, and it's not accessible.

If somebody knows another way to do it, by all means tell me - but I haven't found it.

#14 @wonderboymusic
5 years ago

Adding caption support in the modal was an upgrade from having to write the HTML by hand inside the body of the video shortcode. The work in 3.9 was to figure out how to translate shortcodes into JS objects that can be edited in their own media frame and then kicked back into the editor intact - there is still plenty to do on the a11y front.

#15 in reply to: ↑ 10 @azaozz
5 years ago

Replying to rianrietveld:

In the WYSIWYG editor there is now way, after selecting an image, to enter the options to edit the Image Details panel using a keyboard or screen reader only. Also the options to align an image are unreachable.

This is no longer the case. After an image is selected the user can press Alt+F8 to move the focus to the new image toolbar, Alt+F9 to move to the TinyMCE menu (if shown), Alt+F10 to move to the editor toolbar.

Once the first toolbar button is highlighted, the focus can be moved to the next/previous button with the arrow keys. This works in the image toolbar too. Buttons are activated by pressing Enter or the space bar.

Replying to afercia:

The real issue is editing the image details (alt text, caption, size, advanced options): once an image is inserted into the editor, mouse users can simply select it and click on the "pencil" icon, keyboard users have no options.

Keyboard users can select an image the same way as any other text: Shift+Right Arrow. This is a bit quirky in some browsers but generally works. There are several other "standard" shortcuts when working with text using the Ctrl/Cmd, Alt and Shift keys plus the arrow keys. Note that these are implemented by the browsers so some have better support than others.

To edit the image details without using a mouse:

  1. Focus the editor.
  2. Place the caret in front of the image using the arrow keys.
  3. Press Shift+Right Arrow to select the image.
  4. Press Alt+F8 to move focus to the image toolbar.
  5. Select the "pencil" icon with the arrow keys and press Enter/Space bar to open the modal.
Last edited 5 years ago by azaozz (previous) (diff)

#16 @iseulde
5 years ago

Hm, maybe we should add that information somewhere? E.g. "press ALT+F8 for tools" as a title tag on the image? Is there a standard way of passing such instructions?

#17 follow-up: @azaozz
5 years ago

TinyMCE adds that to the iframe title. We can append the " press Alt+F8 for image toolbar" there (in the translation).

Would be good to add some "Accessibility Help" to the "Help" tab under the admin toolbar too, perhaps include the above 5 steps, etc.

Last edited 5 years ago by azaozz (previous) (diff)

#18 in reply to: ↑ 17 @afercia
5 years ago

Replying to azaozz:

TinyMCE adds that to the iframe title. We can append the " press Alt+F8 for image toolbar" there (in the translation).

I was going to open a ticket for the iframe title :) since it still refers to "ALT-0" for help, which doesn't work anymore. Now there's Alt+Shift+h to open the Keyboard Shortcuts modal.

Please notice also the iframe title is way too long: hearing all that long text read out by screen readers *each time* you focus the editor is a bit annoying. I would prefer just:
"Press ALT-Shift-h for a list of keyboard shortcuts".
(please use hyphens not + in the title attribute)

Unfortunately, the Keyboard shortcuts modal is not accessible. It doesn't get focus, you can't close it with the keyboard etc. and its content needs a refresh, will open a new ticket for this found #28431 and commented there.

About the 5 steps: I guess all testers here knew how to select the image, the point was the missing information about Alt+F8.
Anyway, once users finally move focus to the image toolbar, they should also be able to "close" the image toolbar pressing Escape and move focus back to the editor area. I couldn't find a way to do that.

Finally, in the Keyboard Shortcuts modal there's a section about Distraction Free Writing mode that should be removed. Wondering if there is other text here and there in the codebase still referencing DFW.

Last edited 5 years ago by afercia (previous) (diff)

#19 in reply to: ↑ 13 ; follow-up: @afercia
5 years ago

Replying to joedolson:

One of my biggest concerns about this actually pertains to videos and video captions; right now, the *only* way to add captions to a video within WordPress core is by clicking on the media toolbar in the visual editor after adding a video, and it's not accessible.

For reference, this is the current mce view toolbar, same for audio and playlists:

https://cldup.com/B57zTb8Lvq.png

Since the image toolbar can be focused using Alt+F8 as keyboard shortcut, it would be great to use the same shortcut here too.

#20 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 30757:

TinyMCE, improve accessibility:

  • Return focus to the editor on pressing Escape while the image toolbar is focused.
  • Add a Close button to the Help modal and close it on Escape.
  • Override the title on the editor iframe (read by screen reader apps), replace with the Alt+Shift+H shortcut.
  • Add focus shortcuts descriptions to the Help modal.

Fixes #27642.

#21 in reply to: ↑ 19 @azaozz
5 years ago

  • Keywords needs-patch removed
  • Milestone changed from Future Release to 4.1

Replying to afercia:

Lets open new tickets for the remaining issues mentioned in the comments. Opened #30619 for the wpView toolbar/buttons.

Last edited 5 years ago by azaozz (previous) (diff)

#22 @azaozz
5 years ago

In 30775:

TinyMCE: return focus to the editor after closing the image toolbar. Props afercia, see #27642.

#23 @iseulde
5 years ago

#28431 was marked as a duplicate.

Note: See TracTickets for help on using tickets.