WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 6 weeks ago

Last modified 3 days ago

#37353 closed defect (bug) (fixed)

Unify look and feel of search forms and results across the admin

Reported by: swissspidy Owned by: audrasjb
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots uniform-search has-patch commit
Focuses: ui Cc:

Description

Split out from #37230, here's some feedback from @mapk:

I have a design improvement for the search keyword display.
Let's add a colon after the word 'for'. Then also remove the quotes from around the keyword term and make the keyword bold and black. Like this:

https://cldup.com/MW9tKDYw5v.png

So now if I include quotation marks in my search term, it will make more sense. Let's also make sure to have this reflected in the 'no results found' msg in the table too as I've mocked up below.

https://cldup.com/6gvdhFKkTw.png

Oh, and can we drop the ellipses (...) from the placeholder text in the search input field? Those drive me nuts. AND it looks like we're using Sentence Case (only capitalizing the first word) in the input field's placeholder text too, which is good, but let's have that reflect on the plugin-install.php page as well. Right now the plugin-install.php page is using Title Case.

plugins.php
https://cldup.com/PKDbCtjHRB.png

plugin-install.php
https://cldup.com/mbXBXZfwOC.png

It looks similar on themes.php, comments.php or edit.php, but then again totally different on other screens. See this comment.

Attachments (3)

37353.1.patch (6.6 KB) - added by Mista-Flo 3 months ago.
37353.diff (6.8 KB) - added by helen 6 weeks ago.
37353.2.diff (7.0 KB) - added by helen 6 weeks ago.

Download all attachments as: .zip

Change History (19)

#1 @afercia
4 years ago

Related: #31818.

#2 @afercia
4 years ago

  • Keywords uniform-search added
  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in Slack in #accessibility by cheffheid. View the logs.


4 years ago

#4 @desrosj
11 months ago

  • Milestone set to Future Release

#5 @Mista-Flo
3 months ago

  • Keywords has-patch added; needs-patch removed

@Mista-Flo
3 months ago

#6 @Mista-Flo
3 months ago

Hi @swissspidy,

I have uploaded a patch to apply your suggestions. I haven't took into account your last point about placeholder string in plugin-install.php because it seems it was changed in another ticket, the string is now : "Search plugins..."

#7 @audrasjb
3 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 5.6
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi,
Thanks @Mista-Flo, this patch looks like an useful and long-awaited enhancement.
Moving to 5.6 to see if it can be addressed in the next major release.

I'll checkout the other uniform-search tickets to see if we can bulk fix them in 5.6 :)

This ticket was mentioned in Slack in #core by helen. View the logs.


3 months ago

#9 @audrasjb
2 months ago

I checked this patch again today, and it still applies cleanly.

As there is no committer in the Administration component maintainers group, let's ping @helen as 5.6 core tech lead or @SergeyBiryukov as core tech mentor 🙂

This ticket was mentioned in Slack in #core by helen. View the logs.


6 weeks ago

@helen
6 weeks ago

#11 @helen
6 weeks ago

37353.diff just adds the string change to updates.js since that screen has live search updating. Looks good to me, I like the consistency and I'm sure translators will too. Should probably open another ticket about those ellipses, which are also bothering me now that you have pointed them out :) ~Committing.~

Edit: oops, @sergeybiryukov pointed out that the <strong> tags should be outside of the translatable string as well, going to fix that up.

Last edited 6 weeks ago by helen (previous) (diff)

@helen
6 weeks ago

#12 @helen
6 weeks ago

37353.2.diff moves the <strong> tags out of the translatable strings, *now* I'm going to commit.

#13 @helen
6 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49284:

Administration: Unify search results message on list tables.

This wraps the search string in a <strong> tag, which makes easier to parse visually especially when your search string also contains double quotes.

Props Mista-Flo, mapk, sergeybiryukov.
Fixes #37353.

#14 @SergeyBiryukov
6 weeks ago

In 49286:

Coding Standards: Split long printf() calls for search results for better readability.

Follow-up to [49284].

See #37353.

#15 @SergeyBiryukov
3 days ago

In 49705:

Comments: Correct ending tag placement in the "Search results for: ..." subtitle.

Follow-up to [49284], [49286].

Props Clorith, kebbet, johnbillion, audrasjb, azaozz.
Fixes #51889. See #37353.

#16 @SergeyBiryukov
3 days ago

In 49706:

Comments: Correct ending tag placement in the "Search results for: ..." subtitle.

Follow-up to [49284], [49286].

Props Clorith, kebbet, johnbillion, audrasjb, azaozz.
Reviewed by azaozz, SergeyBiryukov.
Merges [49705] to the 5.6 branch.
Fixes #51889. See #37353.

Note: See TracTickets for help on using tickets.