Filter button should not appear when no posts are available in list

[juhise]

When no posts are available in list then filter button should not appear like bulk action button. This filter button does not do anything, it just confuses the user.

[karmatosed]

Thanks for this @juhise, you are absolutely right that showing a filter when there is nothing to filter isn't a good idea. I'm going to tag and recommend this is committed as your patch looks good to me.

[juhise]

@karmatosed

Thanks for considering it.

[karmatosed]

@melchoyce would you consider this as a good commit to get in? I think it could be.

[karmatosed]

@michaelarestad can you please commit this as the code and patch look good to me and be great to get this one in.

[melchoyce]

@karmatosed Maybe a dev committer could look at this? I'm not comfortable committing PHP.

[swissspidy]

37407.diff​ simplifies the code and fixes the indentation. Otherwise it looks good to me.

Note that this changes behaviour for anyone hooking into the manage_posts_extra_tablenav action and similar hooks. Probably neglectable though.

[karmatosed]

@swissspidy are you cool about committing this then? Would be great to see this get in from the good work @juhise has done.

[swissspidy]

@karmatosed Unfortunately there's one big problem with the current patch: when I filter posts by a category with zero posts attached to it, the tablenav gets hidden.

To fix the original issue, the filter button without a dropdown, the whole if ( $this->has_items() ) check needs to be added to WP_Posts_List_Table::extra_tablenav() instead.

[swissspidy]

I found output buffering to be the only reliable way here. Here's how 37407.3.diff​ looks like in action:

[dipesh.kakadiya]

changes With test case

[dipesh.kakadiya]

Updated test case

[swissspidy]

@dipesh.kakadiya Thanks for the tests, unfortunately they also pass without the fix applied. Also note that we don't get any notification simply for uploaded attachments. You'd need to write a comment as well.

Uploaded a new patch with tests.

[dipesh.kakadiya]

minor typo 'are_now_posts' => 'are_not_posts' for testing functions

[swissspidy]

@dipesh.kakadiya Actually, it should be if_there_are_no_posts, not if_there_are_now_posts.

[swissspidy]

In 38854:

List Tables: Do not show filter button when there are no filter options available.

Props juhise, dipesh.kakadiya, swissspidy.
Fixes #37407.