WordPress.org

Make WordPress Core

Opened 11 months ago

Last modified 3 months ago

#41155 assigned defect (bug)

WordPress 4.8 Admin Sidebar Sub Menu Navigation Issue

Reported by: codexdemon Owned by: mp518
Milestone: Awaiting Review Priority: normal
Severity: trivial Version:
Component: Administration Keywords: good-first-bug has-patch
Focuses: ui Cc:

Description (last modified by DrewAPicture)

Hello Team

As this is really awesome as working with the community of wordpress CMS.

While reviewing themes of WordPress Me and my colleague @amolebonde face issue about accessing sub-menu navigation when we are theme detail page WordPress Admin > Appearance > Themes > Theme Details.

Once we are on Theme Detail page then in case if the user wants to access any Sub Menu Navigation it not shows well, which goes behind the popup theme detail page.

For Ref. Screen Shot Attach https://s4.postimg.org/qvkwram4d/Screen-_Shot-2017-06-25-at-10.26.18-_AM.jpg

Wordpress Version 4.8 Browser Check: SAFARI 10.1.1, Google Chrome 58.0

Attachments (7)

41155.patch (27.0 KB) - added by yahil 11 months ago.
@adamsilverstein if increased #adminmenuwrap selectors z-index 9990 to 10001 we can solve this issue.
41155.1.patch (958 bytes) - added by Girishpanchal 11 months ago.
Hi, @adamsilverstein, Updated theme.css for appearing admin sidebar submenu. Also, Decreased the width of theme overlay for a perfect view of the submenu.
41155.2 (420 bytes) - added by chintanmachhi207 11 months ago.
41155.2.patch (370 bytes) - added by mp518 11 months ago.
z-index decreased
attachment.png (691.5 KB) - added by mp518 11 months ago.
after change screenshot
41155.3.patch (743 bytes) - added by chintanmachhi207 11 months ago.
41155.4.patch (675 bytes) - added by janak007 4 months ago.
Added refreshed patch

Download all attachments as: .zip

Change History (16)

#1 @swissspidy
11 months ago

  • Component changed from General to Administration
  • Focuses accessibility administration removed
  • Keywords needs-patch good-first-bug added
  • Severity changed from normal to trivial
  • Version 4.8 deleted

#2 @adamsilverstein
11 months ago

The css that causes this in theme.css has an inline comment indicating it was added to keep the overlay over 'WP Pointers':

z-index: 10000; /* Over WP Pointers. */

This was added in r33068, and at the time the issue with the submenus going under the overlay was noted and an attempt to resolve was made in r33111.

These z-index conflicts are very difficult to resolve, maybe we should go back to @obenland's original suggestion to not show pointers when the modal is open?

@yahil
11 months ago

@adamsilverstein if increased #adminmenuwrap selectors z-index 9990 to 10001 we can solve this issue.

@Girishpanchal
11 months ago

Hi, @adamsilverstein, Updated theme.css for appearing admin sidebar submenu. Also, Decreased the width of theme overlay for a perfect view of the submenu.

#3 @Girishpanchal
11 months ago

  • Keywords has-patch added; needs-patch removed

Hi, @adamsilverstein

For standard view desktop (1920x1080) Reduced the theme overlay width. I saw that the media is working for (min-width: 1680px).

This change is made in regard to standard desktop view.

#4 @chintanmachhi207
11 months ago

I have add the solution of this issue.

#5 @mp518
11 months ago

Need to just decrease z-index.i have added :)

@mp518
11 months ago

z-index decreased

@mp518
11 months ago

after change screenshot

#6 follow-up: @chintanmachhi207
11 months ago

#41155.3 added to fixed this issue.

This ticket was mentioned in Slack in #core by staceybl. View the logs.


10 months ago

#8 in reply to: ↑ 6 @subrataemfluence
8 months ago

Thank you for the patch! I tested it (on 4.8.1) and it is working perfectly. Also big thanks to @codexdemon for pointing out the issue!

Replying to chintanmachhi207:

#41155.3 added to fixed this issue.

@janak007
4 months ago

Added refreshed patch

#9 @DrewAPicture
3 months ago

  • Description modified (diff)
  • Owner set to mp518
  • Status changed from new to assigned

Assigning to mark the good-first-bug as "claimed".

Note: See TracTickets for help on using tickets.