Make WordPress Core

Opened 7 years ago

Last modified 6 days ago

#41155 reopened defect (bug)

Theme Details dialog hides admin sidebar sub-menu navigation

Reported by: codexdemon's profile codexdemon Owned by: mp518's profile mp518
Milestone: 6.7.1 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch has-screenshots needs-testing has-testing-info
Focuses: ui, css, administration Cc:

Description (last modified by DrewAPicture)

Hello Team

As this is really awesome as working with the community of wordpress CMS.

While reviewing themes of WordPress Me and my colleague @amolebonde face issue about accessing sub-menu navigation when we are theme detail page WordPress Admin > Appearance > Themes > Theme Details.

Once we are on Theme Detail page then in case if the user wants to access any Sub Menu Navigation it not shows well, which goes behind the popup theme detail page.

For Ref. Screen Shot Attach
https://s4.postimg.org/qvkwram4d/Screen-_Shot-2017-06-25-at-10.26.18-_AM.jpg

Wordpress Version 4.8
Browser Check: SAFARI 10.1.1, Google Chrome 58.0

Attachments (14)

41155.patch (27.0 KB) - added by yahil 7 years ago.
@adamsilverstein if increased #adminmenuwrap selectors z-index 9990 to 10001 we can solve this issue.
41155.1.patch (958 bytes) - added by Girishpanchal 7 years ago.
Hi, @adamsilverstein, Updated theme.css for appearing admin sidebar submenu. Also, Decreased the width of theme overlay for a perfect view of the submenu.
41155.2 (420 bytes) - added by chintanmachhi207 7 years ago.
41155.2.patch (370 bytes) - added by mp518 7 years ago.
z-index decreased
attachment.png (691.5 KB) - added by mp518 7 years ago.
after change screenshot
41155.3.patch (743 bytes) - added by chintanmachhi207 7 years ago.
41155.4.patch (675 bytes) - added by janak007 7 years ago.
Added refreshed patch
41155.5.diff (616 bytes) - added by worldweb 5 years ago.
Change z-index from 10000 to 9. Tested and works for me.
41155.5.png (198.6 KB) - added by worldweb 5 years ago.
Screenshot
admin-sidebar.41155.diff (2.1 KB) - added by ralessio 2 years ago.
before.webm (1.2 MB) - added by ralessio 2 years ago.
after.webm (1.2 MB) - added by ralessio 2 years ago.
41155.6.diff (623 bytes) - added by sabernhardt 5 months ago.
increases z-index for admin menu only on Themes screen; sets min-height directly on the overlay backdrop
Screenshot 2024-09-16 at 1.01.46 PM.png (451.6 KB) - added by boogah 7 weeks ago.

Change History (53)

#1 @swissspidy
7 years ago

  • Component changed from General to Administration
  • Focuses accessibility administration removed
  • Keywords needs-patch good-first-bug added
  • Severity changed from normal to trivial
  • Version 4.8 deleted

#2 @adamsilverstein
7 years ago

The css that causes this in theme.css has an inline comment indicating it was added to keep the overlay over 'WP Pointers':

z-index: 10000; /* Over WP Pointers. */

This was added in r33068, and at the time the issue with the submenus going under the overlay was noted and an attempt to resolve was made in r33111.

These z-index conflicts are very difficult to resolve, maybe we should go back to @obenland's original suggestion to not show pointers when the modal is open?

@yahil
7 years ago

@adamsilverstein if increased #adminmenuwrap selectors z-index 9990 to 10001 we can solve this issue.

@Girishpanchal
7 years ago

Hi, @adamsilverstein, Updated theme.css for appearing admin sidebar submenu. Also, Decreased the width of theme overlay for a perfect view of the submenu.

#3 @Girishpanchal
7 years ago

  • Keywords has-patch added; needs-patch removed

Hi, @adamsilverstein

For standard view desktop (1920x1080) Reduced the theme overlay width. I saw that the media is working for (min-width: 1680px).

This change is made in regard to standard desktop view.

@chintanmachhi207
7 years ago

#4 @chintanmachhi207
7 years ago

I have add the solution of this issue.

#5 @mp518
7 years ago

Need to just decrease z-index.i have added :)

@mp518
7 years ago

z-index decreased

@mp518
7 years ago

after change screenshot

#6 follow-up: @chintanmachhi207
7 years ago

#41155.3 added to fixed this issue.

This ticket was mentioned in Slack in #core by staceybl. View the logs.


7 years ago

#8 in reply to: ↑ 6 @subrataemfluence
7 years ago

Thank you for the patch! I tested it (on 4.8.1) and it is working perfectly.
Also big thanks to @codexdemon for pointing out the issue!

Replying to chintanmachhi207:

#41155.3 added to fixed this issue.

@janak007
7 years ago

Added refreshed patch

#9 @DrewAPicture
7 years ago

  • Description modified (diff)
  • Owner set to mp518
  • Status changed from new to assigned

Assigning to mark the good-first-bug as "claimed".

@worldweb
5 years ago

Change z-index from 10000 to 9. Tested and works for me.

@worldweb
5 years ago

Screenshot

#10 @worldweb
5 years ago

  • Keywords has-screenshots added
  • Resolution set to worksforme
  • Status changed from assigned to closed

#11 follow-up: @swissspidy
5 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

@worldweb Why did you close this ticket? There was no fix committed here.

#12 in reply to: ↑ 11 @worldweb
5 years ago

Seems to be done by mistake. Thank you.
Replying to swissspidy:

@worldweb Why did you close this ticket? There was no fix committed here.

This ticket was mentioned in Slack in #core by worldweb. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by worldweb. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by worldweb. View the logs.


5 years ago

This ticket was mentioned in Slack in #forums by worldweb. View the logs.


5 years ago

This ticket was mentioned in Slack in #core-themes by worldweb. View the logs.


5 years ago

This ticket was mentioned in Slack in #core-editor by worldweb. View the logs.


5 years ago

#19 @SergeyBiryukov
5 years ago

  • Component changed from Administration to Themes
  • Focuses administration added
  • Severity changed from trivial to normal

Related: [33068] / [33111] for #31544.

#20 @SergeyBiryukov
5 years ago

#36989 was marked as a duplicate.

#21 @SergeyBiryukov
5 years ago

#48484 was marked as a duplicate.

#22 @sabernhardt
4 years ago

#51464 was marked as a duplicate.

#23 @sabernhardt
4 years ago

  • Focuses css added

#24 @desrosj
4 years ago

#42595 was marked as a duplicate.

#25 @desrosj
4 years ago

#51464 was marked as a duplicate.

#26 @ralessio
2 years ago

Hi, this is my first contribution to WordPress, sorry if I made some mistakes.
Instead, to change the value of the z-index in those classes, I tried a different implementation: I removed the z-index properties because I didn’t see any value in having them.
As you can see, I attached two videos with the current behavior and the fixed behavior.

@ralessio
2 years ago

@ralessio
2 years ago

#27 @sabernhardt
15 months ago

  • Summary changed from WordPress 4.8 Admin Sidebar Sub Menu Navigation Issue to Themes modal hides admin sidebar sub-menu navigation

Related: #58164

This ticket was mentioned in Slack in #core-test by oglekler. View the logs.


8 months ago

#29 @sabernhardt
5 months ago

  • Keywords good-first-bug removed
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Themes modal hides admin sidebar sub-menu navigation to Theme Details dialog hides admin sidebar sub-menu navigation

In addition to a z-index change, 58164-2.patch included a min-height to increase the overlay backdrop's height.

@sabernhardt
5 months ago

increases z-index for admin menu only on Themes screen; sets min-height directly on the overlay backdrop

#30 @sabernhardt
5 months ago

  • Keywords needs-testing added

#31 @sabernhardt
5 months ago

#61334 was marked as a duplicate.

#32 @sabernhardt
5 months ago

  • Milestone changed from Future Release to 6.7

#33 @boogah
7 weeks ago

The patch (41155.6.diff) from @sabernhardt works well in Chrome, Safari, and Firefox — all on desktop.

#34 @huzaifaalmesbah
5 weeks ago

Test Report

Description

Patch tested: 41155.6.diff

Environment

  • WordPress: 6.7-alpha-58576-src
  • PHP: 8.1.29
  • Server: nginx/1.27.1
  • Database: mysqli (Server: 9.0.1 / Client: mysqlnd 8.1.29)
  • Browser: Chrome 129.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Four 1.2
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with patch.

Screenshots

Before Apply Patch After Apply Patch ✅
https://i.ibb.co.com/tx3zx9K/Huzaifa-20240926143303.png https://i.ibb.co.com/T0dqKTy/Huzaifa-20240926143106.png

#35 @lakshmananphp
3 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/41155/41155.6.diff

Environment

  • WordPress: 6.6.2
  • PHP: 8.3.3
  • Server: nginx/1.25.4
  • Database: mysqli (Server: 8.0.33 / Client: mysqlnd 8.3.3)
  • Browser: Chrome 129.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Four 1.2
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0
    • WordPress Beta Tester 3.6.0

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • Tested with Chrome, Firefox and Safari on Desktop

Supplemental Artifacts

Before Patch
https://a.supportally.com/i/KdGLym
After Patch
https://a.supportally.com/i/dIjfV9

#36 @amin7
11 days ago

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/41155/41155.6.diff

Environment

WordPress: 6.7-beta3
PHP: 8.1.23
Database: MySQL 8.0.16
Browser: Chrome 129.0.0.0
OS: Windows 11
Theme: Twenty Twenty-Four 1.2
MU Plugins: None activated


Before patch

Check the screencast: https://d.pr/v/SA7UN5


After patch
Check the screenshot https://d.pr/i/NFmarV


Results
✅ Issue is resolved with the patch.

#37 @desrosj
10 days ago

  • Milestone changed from 6.7 to 6.7.1

Thanks all for the great testing. Unfortunately, time ran out for this one with RC1 due out any moment. I'm going to punt this, but only to 6.7.1 because it seems like we're close.

#38 @sppramodh
6 days ago

  • Keywords has-testing-info added

This ticket was mentioned in Slack in #core-test by sppramodh. View the logs.


6 days ago

Note: See TracTickets for help on using tickets.