Twenty Fourteen: Issues in theme’s Gutenberg support & styles

[laurelfulford]

I’ve re-reviewed the Gutenberg support that added in #45042, primarily to find anything that might have been missed, but also make sure none of the other changes happening during 5.0 development so far created a need for theme updates, too.

I opted to combine my findings per theme into one ticket, since many of the issues showed up in more than one of the default themes — it seemed like it would make it easier to review and commit these fixes, given the timeline.

In Twenty Fourteen, I found these issues:

1. I’d originally added spacing between the columns in the column blocks, which is no longer needed.
2. The Media & Text block does not have spacing underneath it.
3. The cover blocks need to have their styles updated to add the newer non -image- variations of the cover block classes (.wp-block-cover and .wp-block-cover-text)
4. The placeholder text does not use the correct font styles.
5. Editor width selectors can be simplified to just use wp-block in Gutenberg 4.2 RC 1.

[laurelfulford]

1. Columns with unnecessary spacing in theme

[laurelfulford]

2. Media & Text block, without space underneath it

[laurelfulford]

4. Eidtor - placeholder text uses wrong font

[laurelfulford]

1. Columns with spacing removed from theme

[laurelfulford]

2. Media & Text block, with space underneath

[laurelfulford]

4. Eidtor - placeholder text with correct font

[laurelfulford]

45243.patch​ includes fixes for all of the above listed issues, but I only included screenshots where it seemed like it would be helpful!

[davidakennedy]

Extra spacing in media + text block

[davidakennedy]

Hey @laurelfulford, this patch looks solid. I did notice one thing with the media and text block. Having bottom margins on paragraphs and the outer container for the block causes extra spacing. I didn't notice this in other themes so far. We may want to account for this. See my screenshot. Otherwise, patch is good.

[pento]

👍🏻

[laurelfulford]

Thanks @davidakennedy! 45243.1.patch​ makes a small update, to remove the bottom margin from the last child of the Media & Text block.

[laurelfulford]

Twenty Fourteen - remove bottom margin of last child in Media & Text block

[laurelfulford]

Twenty Fourteen - center bullets along with text in list-based widgets that are centred

[laurelfulford]

45243.2.patch​ builds on the above, and fixes an issue @pento spotted in other themes, where bullets in centred widget blocks weren't also centred, which looks a bit odd.

[pento]

😼

[davidakennedy]

The latest patch looks good to me, @laurelfulford.

[laurelfulford]

In 43873:

Twenty Fourteen: Fix issues with theme's Gutenberg support.

A handful of issues were missed in Twenty Fourteen's Gutenberg support, added in #45042. This commit includes the following fixes:

• Update editor placeholder text to use the correct font family.
• Center text and bullets in list-based widget blocks, when block itself is centered.
• Remove unnecessary spacing from the Columns block.
• Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
• Include non "image" variations of the Cover block classes .wp-block-cover and .wp-block-cover-text in the styles.
• Simplify selectors used to set editor width to just .wp-block.

Props pento, davidakennedy.
Fixes #45243.

[SergeyBiryukov]

Reopening for trunk.

[desrosj]

In 44152:

Bundled Themes: Expand initial block editor support.

A handful of items were missed when adding initial support for the new block editor to bundled themes in [43793]-[43800]. This adds support for those missed items.

Props pento, davidakennedy, laurelfulford.

Merges [43869], [43870], [43871], [43872], [43873], [43874], [43875], [43876] to trunk.

Fixes #45238, #45239, #45240, #45242, #45243, #45244, #45245, #45246.