WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45243 closed defect (bug) (fixed)

Twenty Fourteen: Issues in theme’s Gutenberg support & styles

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch, needs-testing, has-screenshots, dev-reviewed, fixed-5.0
Focuses: Cc:

Description

I’ve re-reviewed the Gutenberg support that added in #45042, primarily to find anything that might have been missed, but also make sure none of the other changes happening during 5.0 development so far created a need for theme updates, too.

I opted to combine my findings per theme into one ticket, since many of the issues showed up in more than one of the default themes — it seemed like it would make it easier to review and commit these fixes, given the timeline.

In Twenty Fourteen, I found these issues:

  1. I’d originally added spacing between the columns in the column blocks, which is no longer needed.
  2. The Media & Text block does not have spacing underneath it.
  3. The cover blocks need to have their styles updated to add the newer non -image- variations of the cover block classes (.wp-block-cover and .wp-block-cover-text)
  4. The placeholder text does not use the correct font styles.
  5. Editor width selectors can be simplified to just use wp-block in Gutenberg 4.2 RC 1.

Attachments (12)

twenty-fourteen-columns-before.png (125.8 KB) - added by laurelfulford 3 years ago.
1. Columns with unnecessary spacing in theme
twenty-fourteen-media-text-before.png (158.6 KB) - added by laurelfulford 3 years ago.
2. Media & Text block, without space underneath it
twenty-fourteen-placeholder-font-before.png (10.5 KB) - added by laurelfulford 3 years ago.
4. Eidtor - placeholder text uses wrong font
45243.patch (2.4 KB) - added by laurelfulford 3 years ago.
twenty-fourteen-columns-after.png (127.1 KB) - added by laurelfulford 3 years ago.
1. Columns with spacing removed from theme
twenty-fourteen-media-text-after.png (148.4 KB) - added by laurelfulford 3 years ago.
2. Media & Text block, with space underneath
twenty-fourteen-placeholder-font-after.png (11.0 KB) - added by laurelfulford 3 years ago.
4. Eidtor - placeholder text with correct font
twenty-fourteen-media-text-extra-spacing.png (198.5 KB) - added by davidakennedy 3 years ago.
Extra spacing in media + text block
45243.1.patch (2.7 KB) - added by laurelfulford 3 years ago.
twenty-fourteen-media-text-spacing-last-child.png (136.3 KB) - added by laurelfulford 3 years ago.
Twenty Fourteen - remove bottom margin of last child in Media & Text block
45243.2.patch (3.2 KB) - added by laurelfulford 3 years ago.
twenty-fourteen-centred-bullets-widget-block.png (46.3 KB) - added by laurelfulford 3 years ago.
Twenty Fourteen - center bullets along with text in list-based widgets that are centred

Download all attachments as: .zip

Change History (22)

@laurelfulford
3 years ago

  1. Columns with unnecessary spacing in theme

@laurelfulford
3 years ago

  1. Media & Text block, without space underneath it

@laurelfulford
3 years ago

  1. Eidtor - placeholder text uses wrong font

@laurelfulford
3 years ago

@laurelfulford
3 years ago

  1. Columns with spacing removed from theme

@laurelfulford
3 years ago

  1. Media & Text block, with space underneath

@laurelfulford
3 years ago

  1. Eidtor - placeholder text with correct font

#1 @laurelfulford
3 years ago

45243.patch includes fixes for all of the above listed issues, but I only included screenshots where it seemed like it would be helpful!

@davidakennedy
3 years ago

Extra spacing in media + text block

#2 @davidakennedy
3 years ago

Hey @laurelfulford, this patch looks solid. I did notice one thing with the media and text block. Having bottom margins on paragraphs and the outer container for the block causes extra spacing. I didn't notice this in other themes so far. We may want to account for this. See my screenshot. Otherwise, patch is good.

#3 @pento
3 years ago

  • Keywords dev-reviewed added

👍🏻

#4 @laurelfulford
3 years ago

Thanks @davidakennedy! 45243.1.patch makes a small update, to remove the bottom margin from the last child of the Media & Text block.

@laurelfulford
3 years ago

Twenty Fourteen - remove bottom margin of last child in Media & Text block

@laurelfulford
3 years ago

Twenty Fourteen - center bullets along with text in list-based widgets that are centred

#5 @laurelfulford
3 years ago

45243.2.patch builds on the above, and fixes an issue @pento spotted in other themes, where bullets in centred widget blocks weren't also centred, which looks a bit odd.

#6 @pento
3 years ago

😼

#7 @davidakennedy
3 years ago

The latest patch looks good to me, @laurelfulford.

#8 @laurelfulford
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43873:

Twenty Fourteen: Fix issues with theme's Gutenberg support.

A handful of issues were missed in Twenty Fourteen's Gutenberg support, added in #45042. This commit includes the following fixes:

  • Update editor placeholder text to use the correct font family.
  • Center text and bullets in list-based widget blocks, when block itself is centered.
  • Remove unnecessary spacing from the Columns block.
  • Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
  • Include non "image" variations of the Cover block classes .wp-block-cover and .wp-block-cover-text in the styles.
  • Simplify selectors used to set editor width to just .wp-block.

Props pento, davidakennedy.
Fixes #45243.

#9 @SergeyBiryukov
3 years ago

  • Keywords fixed-5.0 added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for trunk.

#10 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44152:

Bundled Themes: Expand initial block editor support.

A handful of items were missed when adding initial support for the new block editor to bundled themes in [43793]-[43800]. This adds support for those missed items.

Props pento, davidakennedy, laurelfulford.

Merges [43869], [43870], [43871], [43872], [43873], [43874], [43875], [43876] to trunk.

Fixes #45238, #45239, #45240, #45242, #45243, #45244, #45245, #45246.

Note: See TracTickets for help on using tickets.