Opened 15 years ago
Last modified 6 years ago
#10762 assigned defect (bug)
Bulk editing creates invalid URIs
Reported by: | hakre | Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | 2.8.4 |
Component: | Quick/Bulk Edit | Keywords: | needs-patch |
Focuses: | Cc: |
Description
They simply get too long for example if you move 999 posts to trash. It might be helpfull to switch to the post form method.
Attachments (1)
Change History (25)
#2
@
15 years ago
Bulk Edit submits the main form on the page which uses GET. It could be refactored to use POST but that's not a trivial task.
#3
follow-up:
↓ 6
@
15 years ago
For me it seems that replacing $_GET with $_REQUEST is pretty trivial. It might not be trivial to test if that's working then.
#6
in reply to:
↑ 3
@
15 years ago
- Milestone changed from 2.9 to 3.0
Replying to hakre:
For me it seems that replacing $_GET with $_REQUEST is pretty trivial. It might not be trivial to test if that's working then.
If you bulk-delete posts, the IDs are passed back to the form, that way the undo button can be generated. So hidden fields would also need to be created to ensure that the URI can't get too long.
It's a complicated process to go through however many forms use bulk actions and redo all of the add_query_arg code and such. Definitely quite the task.
#7
@
15 years ago
- Milestone changed from 3.0 to Future Release
As this isnt a Regression from a previous version, and there is no patch, I'm moving to Future Release.
#11
@
14 years ago
- Milestone changed from Future Release to 3.1
- Resolution set to fixed
- Status changed from assigned to closed
#12
@
14 years ago
- Component changed from Accessibility to Administration
- Keywords gsoc removed
- Milestone changed from 3.1 to Future Release
- Resolution fixed deleted
- Status changed from closed to reopened
#16335. We'll need to fix this in conjunction with ajax redux.
#21
@
9 years ago
Thought - why not use the $removable_query_args
feature introduced in 4.2 that allows us to remove certain query parameters from the URL with JS on page load? It won't work for everyone, but it's a rather easy to apply fix(instead of digging through all of the places where we'd have to use remove_query_arg()
for form actions). I've submitted a simple patch that does exactly that, while seemingly not breaking anything(the "Undo" link still works fine).
Never did understand why a GET request is used in this case. Should use POST.