WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 3 weeks ago

#10762 assigned defect (bug)

Bulk editing creates invalid URIs

Reported by: hakre Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 2.8.4
Component: Quick/Bulk Edit Keywords: needs-patch
Focuses: Cc:

Description

They simply get too long for example if you move 999 posts to trash. It might be helpfull to switch to the post form method.

Attachments (1)

misc-10762-1.diff (404 bytes) - added by nikolov.tmw 3 weeks ago.
Adds 'ids' to the list of query args that should be removed from admin URLs

Download all attachments as: .zip

Change History (22)

comment:1 @scribu6 years ago

Never did understand why a GET request is used in this case. Should use POST.

comment:2 @azaozz6 years ago

Bulk Edit submits the main form on the page which uses GET. It could be refactored to use POST but that's not a trivial task.

comment:3 follow-up: @hakre6 years ago

For me it seems that replacing $_GET with $_REQUEST is pretty trivial. It might not be trivial to test if that's working then.

comment:4 @hakre6 years ago

Related: #11114

comment:5 @hakre6 years ago

Related: #10360

comment:6 in reply to: ↑ 3 @nacin5 years ago

  • Milestone changed from 2.9 to 3.0

Replying to hakre:

For me it seems that replacing $_GET with $_REQUEST is pretty trivial. It might not be trivial to test if that's working then.

If you bulk-delete posts, the IDs are passed back to the form, that way the undo button can be generated. So hidden fields would also need to be created to ensure that the URI can't get too long.

It's a complicated process to go through however many forms use bulk actions and redo all of the add_query_arg code and such. Definitely quite the task.

comment:7 @dd325 years ago

  • Milestone changed from 3.0 to Future Release

As this isnt a Regression from a previous version, and there is no patch, I'm moving to Future Release.

comment:8 @scribu5 years ago

  • Keywords gsoc added
  • Owner set to scribu
  • Status changed from new to assigned

comment:10 @voyagerfan57615 years ago

  • Cc WordPress@… added

comment:11 @scribu5 years ago

  • Milestone changed from Future Release to 3.1
  • Resolution set to fixed
  • Status changed from assigned to closed

comment:12 @nacin4 years ago

  • Component changed from Accessibility to Administration
  • Keywords gsoc removed
  • Milestone changed from 3.1 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened

#16335. We'll need to fix this in conjunction with ajax redux.

comment:13 @scribu3 years ago

  • Owner scribu deleted
  • Status changed from reopened to assigned

comment:14 @scribu3 years ago

#22062 was marked as a duplicate.

comment:15 @scribu3 years ago

#22062 was marked as a duplicate.

comment:16 @ocean902 years ago

#24323 was marked as a duplicate.

comment:17 @ocean9016 months ago

  • Component changed from Administration to Quick/Bulk Edit

comment:18 @ocean9013 months ago

#28192 was marked as a duplicate.

comment:19 @ocean9010 months ago

#29049 was marked as a duplicate.

comment:20 @SergeyBiryukov10 months ago

#29116 was marked as a duplicate.

@nikolov.tmw3 weeks ago

Adds 'ids' to the list of query args that should be removed from admin URLs

comment:21 @nikolov.tmw3 weeks ago

Thought - why not use the $removable_query_args feature introduced in 4.2 that allows us to remove certain query parameters from the URL with JS on page load? It won't work for everyone, but it's a rather easy to apply fix(instead of digging through all of the places where we'd have to use remove_query_arg() for form actions). I've submitted a simple patch that does exactly that, while seemingly not breaking anything(the "Undo" link still works fine).

Note: See TracTickets for help on using tickets.