WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 9 days ago

#14179 new defect (bug)

Theme asking to update (theme with same name on WordPress.org)

Reported by: design_dolphin Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: Themes Keywords:
Focuses: Cc:

Description

I have a theme with a certain name, but there is a theme with the same name in the WordPress themes directory. So now my theme keeps showing an update message.

Proposed solutions:

  1. Add unique hash to each uploaded theme in the themes directory. This way even if someone has a home-grown theme which happens to have the same name, but are not going to upload it to the themes directory, there won't be a conflict. (You could change the name of the theme, but who is to say someone won't upload a theme that also has that name.)
  1. Add more fields to the updater check such as author, and date/ time created. This could mean though that theme authors would always have to add this during theme creation, and know why they are doing this. Possibly adding a extra complicating step in WordPress theme design. Otherwise at some point they or their client could start getting a update message for their theme.

Attachments (1)

23318-upgrade-header.diff (3.4 KB) - added by meloniq 23 months ago.
Adds optional "Upgrade" header for plugins and themes. New header defaults to 'true', when "Upgrade: false" is set, it excludes plugin/theme from checking for updates in WP API.

Download all attachments as: .zip

Change History (18)

#1 @GautamGupta
6 years ago

Same with plugins..

#2 @filosofo
6 years ago

  • Component changed from Themes to WordPress.org

See #13928 also for a similar issue with plugins.

#3 @sean212
6 years ago

I'd go with solution #2, because adding a hash for all already existing plugins would be quite a hassle, being that there's over 10,000. :D

#4 @nacin
6 years ago

  • Milestone changed from Awaiting Review to Future Release

#5 @SergeyBiryukov
4 years ago

  • Component changed from WordPress.org site to Themes
  • Milestone changed from Future Release to WordPress.org

Related: #23318

#6 @SergeyBiryukov
3 years ago

#26645 was marked as a duplicate.

#7 @meloniq
3 years ago

  • Cc meloniq@… added

#8 @dreamwhisper
3 years ago

  • Cc dreamwhisper added

#9 @SergeyBiryukov
2 years ago

#28954 was marked as a duplicate.

@meloniq
23 months ago

Adds optional "Upgrade" header for plugins and themes. New header defaults to 'true', when "Upgrade: false" is set, it excludes plugin/theme from checking for updates in WP API.

#10 @meloniq
23 months ago

Patch 23318-upgrade-header.diff adds optional "Upgrade" header for plugins and themes. New header defaults to 'true', when "Upgrade: false" is set, it excludes plugin/theme from checking for updates in WP API.

(Patch was originally submitted to #23318)

#11 @nhuja
19 months ago

This is a major issue. Many of our clients updated to a different "free" version theme by different author with same theme name and we are at a loss. Can we not simply check for Author for this auto update? We are losing clients!!

#12 @dd32
18 months ago

#31969 was marked as a duplicate.

#13 @ocean90
11 months ago

#34370 was marked as a duplicate.

#14 @JeroenReumkens
10 months ago

Same thing here. Would be great if the check would be a little more reliable. Luckily I noticed that Wordpress told me about a theme update before my theme was released to the client, so I could change the theme name. But in theory it could mean that one day someone releases a theme with the exact same name as one of the themes I've build (probably months / years ago). If the client notices this message earlier then I do, they will have a broken site.

Hope the update check can be improved :)

This ticket was mentioned in Slack in #core by benoitchantre. View the logs.


8 months ago

This ticket was mentioned in Slack in #core by dd32. View the logs.


8 months ago

This ticket was mentioned in Slack in #core by sergey. View the logs.


9 days ago

Note: See TracTickets for help on using tickets.