Notices when WP_DEBUG is set

[simonwheatley]

Steps to reproduce:

1. Define the constant WP_DEBUG in wp_config.php

2. Select the edit link from a single post page which has no tags

3. Check the PHP error log, and you should see:

Notice:Undefined variable: _wp_original_http_referrer in /Users/simon/Projects/WordPress-2.5/site/wp-admin/edit-form-advanced.php:6

Notice:Undefined variable: original_title in /Users/simon/Projects/WordPress-2.5/site/wp-admin/includes/post.php:639

Notice:Undefined property: stdClass::$args in /Users/simon/Projects/WordPress-2.5/site/wp-includes/taxonomy.php:1066

Notice:Undefined offset: 2 in /Users/simon/Projects/WordPress-2.5/site/wp-includes/rewrite.php(140) : eval()'d code:1

Notice:Undefined index: _wp_original_http_referer in /Users/simon/Projects/WordPress-2.5/site/wp-admin/edit-page-form.php:4

Notice:Undefined variable: temp_ID in /Users/simon/Projects/WordPress-2.5/site/wp-admin/edit-page-form.php:26

Notice:Undefined variable: post_ID in /Users/simon/Projects/WordPress-2.5/site/wp-admin/edit-page-form.php:32

The proposed patch, edit_posts_no_tags.patch, supresses the errors caused by trying to access unset $_GET vars, sets or tests other vars/properties before using them in I statements, lowers the error reporting before evaling $query in rewrite.php

[simonwheatley]

Patch to reduce Notices when creating and editing pages/posts

[westi]

2.6 is a more appropriate target for these fixes.

Just adding @ is not the right fix.

[jacobsantos]

This most likely was fixed with another notices patch. I think there should only be one ticket for notices and warnings fixes per WordPress version.

[jacobsantos]

See #6671, #6670, #6667, #6666, #5607, #5266

[jacobsantos]

See #5105

[jacobsantos]

See #6958

[jacobsantos]

See #6959

[santosj]

Fix massive amount of notices in wp-includes and wp-admin

[santosj]

Patch corrects a lot of notices.

[ryan]

How about adding this to the top of the edit forms so that we don't have to do a bunch of isset checks later on?

if ( !isset($foo_id) )
    $foo_id = 0;

[santosj]

Replying to ryan:

How about adding this to the top of the edit forms so that we don't have to do a bunch of isset checks later on?

Indeed.

[santosj]

Fixes a lot of notices in wp-admin and wp-includes directories with suggestion from Ryan, based off of r8584

[santosj]

I did test the changes, but there might be some odd side effects possible with some changes. Works for me! Some pages are unusable without patch when using WP_DEBUG. We should encourage its use, but I really can't see how people will be able to use it.

There will need to be several more patches to cover the full scope of all of the Administration Panel pages, as well as the visitor pages.

[westi]

Throwing the current patch at trunk.

[westi]

(In [8589]) Lots of fixes for Notices when WP_DEBUG is set. See #6669 props santosj.

[santosj]

Patch in this ticket fixed issues found in #7411.

[santosj]

See #7509 for updated patch for WordPress notices.