Opened 5 months ago
Closed 3 weeks ago
#64230 closed task (blessed) (fixed)
Update/Audit NPM Dependencies for 7.0
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 7.0 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Build/Test Tools | Keywords: | has-patch |
| Focuses: | Cc: |
Description
Previously:
- #63171 (6.9)
- #62220 (6.8)
- #62137 (6.7)
- #61498 (6.6)
- #59658 (6.5)
- #58863 (6.4)
- #57657 (6.3)
- #57535 (6.2)
- #56641 (6.1)
- #54727 (6.0)
- #53361 (5.9)
- #52624 (5.8)
- #51801 (5.7)
- #50769 (5.6)
- #49768 (5.5)
- #49547 (5.4)
- #48203 (5.3)
- #46039 (5.1)
- #45064 (5.0)
- #38199 (4.7)
- #36520 (4.6)
- #35104 (4.5)
- #34177 (4.4)
- #31700 (4.3)
- #31489 (4.2)
- #30141 (4.1)
- #27340 (4.0)
- #26073 (3.9)
Change History (9)
This ticket was mentioned in PR #10961 on WordPress/wordpress-develop by @desrosj.
8 weeks ago
#1
- Keywords has-patch added
#2
@
5 weeks ago
@aakashverma1 called attention to updating cssnano and svgo on #64833 (involves multiple default themes).
@desrosj commented on PR #10961:
4 weeks ago
#4
I've been testing a workflow I created for Core-64878 while I worked on this. I have a PR on my fork that compares the changes to the build directory as a result of this (bot comment here).
Only the expected files are changing: files built with Webpack, and files that reference those files by hashes.
The exceptions are the contents of wp/includes/build/** (these are orphaned files seemingly due to ignore properties and the build server not cleaning up after itself), an unremoved icon, and the version.php file being updated (expected).
@jonsurrell commented on PR #10961:
4 weeks ago
#5
I reviewed the version changes in package.json and they appear correct.
I did not review all the changes in package-lock.json, but noticed that it's grown substantially. We could run npm dedupe to trim dependencies down some.
I notice that there's a dependency on underscore@1.13.7 while `1.13.8` is the latest. Shall we upgrade that here?
@desrosj commented on PR #10961:
4 weeks ago
#6
I reviewed the version changes in
package.jsonand they appear correct.
Thanks!
I did not review all the changes in
package-lock.json, but noticed that it's grown substantially. We could runnpm dedupeto trim dependencies down some.
I've gone and run a final npm audit fix. This increased the size of package-lock.json by 200 additional lines. Running npm dedupe decreased the overall change to to +~1,000 instead of +~1,100.
I notice that there's a dependency on
underscore@1.13.7while `1.13.8` is the latest. Shall we upgrade that here?
underscore is a not a devDependency. Updates to dependencies that are included in the built source are handled as enhancements, so it needs to wait until 7.0.1 or 7.1.
#7
@
4 weeks ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from new to closed
In 62050:
Trac ticket: Core-64230
## Use of AI Tools