Changeset 54970

Timestamp:

12/14/2022 01:50:06 PM (21 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames $parent to $parent_post in WP_REST_Revisions_Controller::get_parent().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

@@ -135 +135 @@
      * @since 4.7.2
      *
-     * @param int $parent Supplied ID.
+     * @param int $parent_post Supplied ID.
      * @return WP_Post|WP_Error Post object if ID is valid, WP_Error otherwise.
      */
-    protected function get_parent( $parent ) {
+    protected function get_parent( $parent_post ) {
         $error = new WP_Error(
             'rest_post_invalid_parent',
@@ -144 +144 @@
             array( 'status' => 404 )
         );
-        if ( (int) $parent <= 0 ) {
+
+        if ( (int) $parent_post <= 0 ) {
             return $error;
         }
 
-        $parent = get_post( (int) $parent );
-        if ( empty( $parent ) || empty( $parent->ID ) || $this->parent_post_type !== $parent->post_type ) {
+        $parent_post = get_post( (int) $parent_post );
+
+        if ( empty( $parent_post ) || empty( $parent_post->ID )
+            || $this->parent_post_type !== $parent_post->post_type
+        ) {
             return $error;
         }
 
-        return $parent;
+        return $parent_post;
     }