Make WordPress Core

Changeset 54970


Ignore:
Timestamp:
12/14/2022 01:50:06 PM (18 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames $parent to $parent_post in WP_REST_Revisions_Controller::get_parent().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

    r54121 r54970  
    135135     * @since 4.7.2
    136136     *
    137      * @param int $parent Supplied ID.
     137     * @param int $parent_post Supplied ID.
    138138     * @return WP_Post|WP_Error Post object if ID is valid, WP_Error otherwise.
    139139     */
    140     protected function get_parent( $parent ) {
     140    protected function get_parent( $parent_post ) {
    141141        $error = new WP_Error(
    142142            'rest_post_invalid_parent',
     
    144144            array( 'status' => 404 )
    145145        );
    146         if ( (int) $parent <= 0 ) {
     146
     147        if ( (int) $parent_post <= 0 ) {
    147148            return $error;
    148149        }
    149150
    150         $parent = get_post( (int) $parent );
    151         if ( empty( $parent ) || empty( $parent->ID ) || $this->parent_post_type !== $parent->post_type ) {
     151        $parent_post = get_post( (int) $parent_post );
     152
     153        if ( empty( $parent_post ) || empty( $parent_post->ID )
     154            || $this->parent_post_type !== $parent_post->post_type
     155        ) {
    152156            return $error;
    153157        }
    154158
    155         return $parent;
     159        return $parent_post;
    156160    }
    157161
Note: See TracChangeset for help on using the changeset viewer.